Log4j 2
  1. Log4j 2
  2. LOG4J2-566

Configure RollingRandomAccessFileAppender buffer size

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-rc1
    • Fix Version/s: 2.0-rc2
    • Component/s: Appenders
    • Labels:
      None

      Description

      Make buffer size of RollingRandomAccessFileAppender configurable similar to what was done for RandomAccessFileAppender in LOG4J2-402.

      1. LOG4J2-566.patch
        13 kB
        Matt Sicker
      2. RollingRandomAccessFile.zip
        7 kB
        Luigi Alice

        Activity

        Hide
        Remko Popma added a comment -

        I think it was my intention that Luigi (who pointed this out to us in LOG4J2-402) would close this issue. I didn't clearly mention that though. It is fine to close it, thanks!

        Show
        Remko Popma added a comment - I think it was my intention that Luigi (who pointed this out to us in LOG4J2-402 ) would close this issue. I didn't clearly mention that though. It is fine to close it, thanks!
        Hide
        Matt Sicker added a comment -

        Again, you're the reporter! Closing.

        Show
        Matt Sicker added a comment - Again, you're the reporter! Closing.
        Hide
        Remko Popma added a comment -

        Fixed in revision 1592539.
        Please verify and close.

        Show
        Remko Popma added a comment - Fixed in revision 1592539. Please verify and close.
        Hide
        Gary Gregory added a comment -

        The unit tests should at the very least make sure that the value configured is used, perhaps by checking the ivar and the allocated buffer.

        Show
        Gary Gregory added a comment - The unit tests should at the very least make sure that the value configured is used, perhaps by checking the ivar and the allocated buffer.
        Hide
        Matt Sicker added a comment -

        Whoops, didn't notice he used tabs. Converted to spaces.

        Show
        Matt Sicker added a comment - Whoops, didn't notice he used tabs. Converted to spaces.
        Hide
        Matt Sicker added a comment -

        Here, I converted his files into a patch. Had to fix an error (probably due to an API change at some point). I could commit this as the tests all pass, but I figured I'd get some review, too.

        Show
        Matt Sicker added a comment - Here, I converted his files into a patch. Had to fix an error (probably due to an API change at some point). I could commit this as the tests all pass, but I figured I'd get some review, too.
        Hide
        Gary Gregory added a comment -

        You can only commit if you are a committer, which you would know.

        Please attach your changes as a diff file and we'll take a look.

        Thank you!

        Show
        Gary Gregory added a comment - You can only commit if you are a committer, which you would know. Please attach your changes as a diff file and we'll take a look. Thank you!
        Hide
        Luigi Alice added a comment -

        I don't know if I have permissions to commit changes but I don't think so.

        Show
        Luigi Alice added a comment - I don't know if I have permissions to commit changes but I don't think so.
        Hide
        Remko Popma added a comment -

        Oh wow, that is fast! Would it be possible for you to submit this as a patch?

        Show
        Remko Popma added a comment - Oh wow, that is fast! Would it be possible for you to submit this as a patch?
        Hide
        Luigi Alice added a comment -

        I've attached a possible implementation.

        Show
        Luigi Alice added a comment - I've attached a possible implementation.

          People

          • Assignee:
            Remko Popma
            Reporter:
            Remko Popma
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development