[LOG4J2-552] Logic of isInstanceOf are not consistent in log4j-api's Log4jMarker and log4j-slf4j-impl's MarkerWrapper

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 2.0-rc1
• Component/s: API, SLF4J Bridge
• Assignee: Unassigned
• Reporter: RainJ
• Created: 26/Feb/14 10:17
• Updated: 01/Mar/14 00:05
• Resolved: 01/Mar/14 00:05

Description

The logic of isInstanceOf is not consistent for Marker implements in log4j-api's Log4jMarker and log4j-slf4j-iml's MarkerWrapper.
In Log4jMarker
---------------------------------------------
@Override
public boolean isInstanceOf(final String name) {
if (name == null)

{ throw new IllegalArgumentException("A marker name is required"); }

Marker toTest = this;
do {
if (name.equals(toTest.getName()))

{ return true; }

toTest = toTest.getParent();
} while (toTest != null);
return false;
}
---------------------------------------------
in MarkerWrapper
---------------------------------------------
@Override
public boolean isInstanceOf(final Marker marker) {
if (marker == null)

{ throw new IllegalArgumentException("A marker parameter is required"); }

if (marker instanceof MarkerWrapper)

{ return contains((MarkerWrapper) marker); }

else

{ return contains(marker.getName()); }

}

@Override
public boolean isInstanceOf(final String name) {
if (name == null)

{ throw new IllegalArgumentException("A marker name is required"); }

return contains(name);
}
-----------------------------------------

in Log4jMarker, the isInstanceOf means the marker is instance of itself or its parent

in MarkerWrapper, the isInstance of means the marker is instance of itself or its children