Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-454

TimeBasedTriggeringPolicy should use event time millis

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta9
    • Fix Version/s: None
    • Component/s: Appenders
    • Labels:
      None

      Description

      In the TimeBasedTriggeringPolicy.java, it's using system current timestamp to compare with nextRollover time:
      Code:

              final long now = System.currentTimeMillis();
              if (now > nextRollover) { ... ....
      

      But I think, it should use the event time millis:
      Code:

      	final long now = event.getMillis();
      	if (now > nextRollover) {... ...
      

      According the event time millis, it can be System.currentTimeMillis or Message's timestamp if the message implements TimestampMessage.

      So I think the event.getMillis() would be the best choice for comparing with nextRollover time.

        Attachments

          Activity

            People

            • Assignee:
              remkop@yahoo.com Remko Popma
              Reporter:
              robinzt robin zhang tao
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: