[LOG4J2-454] TimeBasedTriggeringPolicy should use event time millis

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0-beta9
• Component/s: Appenders
• Assignee: Remko Popma
• Reporter: robin zhang tao
• Created: 22/Nov/13 07:46
• Updated: 22/Dec/13 09:50
• Resolved: 22/Dec/13 09:08

Description

In the TimeBasedTriggeringPolicy.java, it's using system current timestamp to compare with nextRollover time:
Code:

        final long now = System.currentTimeMillis();
        if (now > nextRollover) { ... ....

But I think, it should use the event time millis:
Code:

	final long now = event.getMillis();
	if (now > nextRollover) {... ...

According the event time millis, it can be System.currentTimeMillis or Message's timestamp if the message implements TimestampMessage.

So I think the event.getMillis() would be the best choice for comparing with nextRollover time.