Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-3472

Allow configuration of custom Disruptor WaitStrategy

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.17.2
    • 2.18.0
    • Configuration, Core
    • None

    Description

      See also LOG4J2-2858.

      Currently Log4j allows a fixed set of disruptor WaitStrategies to be configured. The current code has two drawbacks:

      • the fixed set does not include all built-in WaitStrategies that the disruptor library provides
      • the configuration does not allow custom implementations of the com.lmax.disruptor.WaitStrategy interface.

      Proposal:

      Introduce a org.apache.logging.log4j.core.async.WaitStrategyProvider interface. Users may configure instances of this interface by setting system property log4j2.asyncWaitStrategyProvider.

      Proposed implementation is to modify DisruptorUtil::createWaitStrategy to check for the existence of this system property, before doing anything else. If this property exists and a class can be instantiated based on the value of this property, and the resulting WaitStrategyProvider instance provides a non-null com.lmax.disruptor.WaitStrategy instance, then this waitstrategy is returned from DisruptorUtil::createWaitStrategy. Otherwise, we fall back to the existing logic.

      Note that for simplicity I do not propose to have separate system properties for Async Loggers and Async LoggerConfigs.

      Attachments

        Issue Links

          Activity

            People

              rpopma Remko Popma
              rpopma Remko Popma
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: