Log4j 2
  1. Log4j 2
  2. LOG4J2-333

Match artifact ids with Maven module names

    Details

      Description

      actual directory names don't match artifact ids:

      $ grep "^  <artifact" */pom.xml
      api/pom.xml:  <artifactId>log4j-api</artifactId>
      core/pom.xml:  <artifactId>log4j-core</artifactId>
      dist/pom.xml:  <artifactId>log4j-distribution</artifactId>
      flume-ng/pom.xml:  <artifactId>log4j-flume-ng</artifactId>
      jcl-bridge/pom.xml:  <artifactId>log4j-jcl</artifactId>
      jmx-gui/pom.xml:  <artifactId>log4j-jmx-gui</artifactId>
      log4j12-api/pom.xml:  <artifactId>log4j-1.2-api</artifactId>
      log4j-to-slf4j/pom.xml:  <artifactId>log4j-to-slf4j</artifactId>
      osgi/pom.xml:  <artifactId>log4j-osgi</artifactId>
      samples/pom.xml:  <artifactId>log4j-samples</artifactId>
      slf4j-impl/pom.xml:  <artifactId>log4j-slf4j-impl</artifactId>
      taglib/pom.xml:  <artifactId>log4j-taglib</artifactId>

      the only exception is log4j-to-slf4j

      doing so will cause you problems with automatic calculations done by Maven for site: you're going to fight against Maven, which is good neither for you nor Maven (I already heard a lot about "maven site plugin is broken"...)

      you should really rename directories in svn to match artifactIds (which will cause less trouble than renaming artifact ids to match directory names IMHO)

        Activity

        Hervé Boutemy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hervé Boutemy added a comment -

        everything is ok now: convention used, then calculated default values match

        Show
        Hervé Boutemy added a comment - everything is ok now: convention used, then calculated default values match
        Hide
        Gary Gregory added a comment -

        Hervé?

        Show
        Gary Gregory added a comment - Hervé?
        Gary Gregory made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Gary Gregory [ garydgregory ]
        Fix Version/s 2.0-beta9 [ 12324756 ]
        Resolution Fixed [ 1 ]
        Hide
        Gary Gregory added a comment - - edited

        Hervé,

        Committed revision 1517550.

        Please verify and close, or propose more clean ups Thank you/Merci!

        Gary

        Show
        Gary Gregory added a comment - - edited Hervé, Committed revision 1517550. Please verify and close, or propose more clean ups Thank you/Merci! Gary
        Gary Gregory made changes -
        Field Original Value New Value
        Summary match artifact ids with Maven module names Match artifact ids with Maven module names
        Hide
        Hervé Boutemy added a comment -

        that would be great, IMHO, but of course, this is a decision for your dev team, not myself

        notice that if you choose not to rename directories (you still can), you should then manually define scm section in every submodule since actual auto-calculated value is wrong (uses artifact-id: try mvn help:effective-pom on a submodule and you'll see)

        Show
        Hervé Boutemy added a comment - that would be great, IMHO, but of course, this is a decision for your dev team, not myself notice that if you choose not to rename directories (you still can), you should then manually define scm section in every submodule since actual auto-calculated value is wrong (uses artifact-id: try mvn help:effective-pom on a submodule and you'll see)
        Hide
        Gary Gregory added a comment -

        Let's do this before the next beta, ok?

        Show
        Gary Gregory added a comment - Let's do this before the next beta, ok?
        Hide
        Hervé Boutemy added a comment -

        after stable release, users won't expect directory name changes in svn, so you'd better make your mind on such issue as soon as possible

        Show
        Hervé Boutemy added a comment - after stable release, users won't expect directory name changes in svn, so you'd better make your mind on such issue as soon as possible
        Hide
        Remko Popma added a comment -

        Is "Blocker" the correct priority for this issue? To me this priority should only be used for issues that MUST be fixed before the next release (and preferably - and I admit this is more vague - for issues that severely and directly impact many log4j users)...

        Show
        Remko Popma added a comment - Is "Blocker" the correct priority for this issue? To me this priority should only be used for issues that MUST be fixed before the next release (and preferably - and I admit this is more vague - for issues that severely and directly impact many log4j users)...
        Hide
        Hervé Boutemy added a comment -

        yes, this seems to be unknown to many people: I don't know where to document it better

        I added it in POM descriptor reference for 3.1.0:

        if you find other locations where such information would be valuable, don't hesitate to give me pointers, since this is a common problem people are facing (with the "maven-site-plugin is broken" conclusion that makes me sick)

        Show
        Hervé Boutemy added a comment - yes, this seems to be unknown to many people: I don't know where to document it better I added it in POM descriptor reference for 3.1.0: http://maven.apache.org/ref/3.1.0/maven-model/maven.html#class_project for url and modules/module http://maven.apache.org/ref/3.1.0/maven-model/maven.html#class_scm for scm urls if you find other locations where such information would be valuable, don't hesitate to give me pointers, since this is a common problem people are facing (with the "maven-site-plugin is broken" conclusion that makes me sick)
        Hide
        Gary Gregory added a comment -

        I was not aware of that! Thank you Hervé.

        Show
        Gary Gregory added a comment - I was not aware of that! Thank you Hervé.
        Hervé Boutemy created issue -

          People

          • Assignee:
            Gary Gregory
            Reporter:
            Hervé Boutemy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development