Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-3310

maybe some log4j-api-scala methods should be changed back to being macros

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • Scala 12.1
    • Scala API
    • None

    Description

      In hindsight, I suspect that I went too far in LOG4J2-3184 with changing methods that used macros into ones that just delegated to base logger at runtime.

      These methods are among those that possibly should be macro based, as it might be nice to adjust the pre-compiled code to add the level isEnabled check.

       

      def apply(inline level: Level, inline marker: Marker, inline message: Message): Unit

      def apply(inline level: Level, inline marker: Marker, inline message: AnyRef): Unit

      def apply(inline level: Level, inline marker: Marker, inline message: Message, inline cause: Throwable): Unit

      def apply(inline level: Level, inline marker: Marker, inline message: AnyRef, inline cause: Throwable): Unit

      def apply(inline level: Level, inline message: Message): Unit

      def apply(inline level: Level, inline message: AnyRef): Unit

      def apply(inline level: Level, inline message: Message, inline cause: Throwable): Unit

      def apply(inline level: Level, inline message: AnyRef, inline cause: Throwable): Unit

      def traceEntry(inline params: AnyRef*): EntryMessage

      def traceEntry(inline message: Message): EntryMessage

      def traceExit(inline entryMessage: EntryMessage): Unit

      def traceExit[R](inline entryMessage: EntryMessage, result: R): R

      def traceExit[R](inline message: Message, result: R): R

      def throwing[T <: Throwable](inline level: Level, inline t: T): T

      def catching(inline level: Level, inline t: Throwable): Unit

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            pj.fanning PJ Fanning
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10m
                10m