Log4j 2
  1. Log4j 2
  2. LOG4J2-317

Rename FastFileAppender and FastRollingFileAppender to RandomAccessFileAppender and RollingRandomAccessFileAppender

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta8
    • Fix Version/s: 2.0-beta9
    • Component/s: Appenders, Core
    • Labels:
      None

      Description

      FastFileAppender and FastRollingFileAppender need more descriptive names.

      Suggestions so far:

      • RandomAccessFileAppender
      • RAFileAppender
      • RAFAppender
      • RafAppender

      (please feel free to add to the above list)


      Resolution: The new class names are RandomAccessFileAppender and RollingRandomAccessFileAppender

        Activity

        Hide
        Gary Gregory added a comment -

        I like RandomAccessFileAppender, it makes sense next to FileAppender.

        If we decide to replace FileAppender with RandomAccessFileAppender before the 2.0 release and only have one file appender, we can just move the RandomAccessFileAppender code into FileAppender. Same for the class names with similar names.

        For now, I think we should keep both, at least until we've all played with them more.

        Show
        Gary Gregory added a comment - I like RandomAccessFileAppender , it makes sense next to FileAppender . If we decide to replace FileAppender with RandomAccessFileAppender before the 2.0 release and only have one file appender, we can just move the RandomAccessFileAppender code into FileAppender . Same for the class names with similar names. For now, I think we should keep both, at least until we've all played with them more.
        Hide
        Remko Popma added a comment -

        Tricky to find a good name for the rolling version:
        rename FastRollingFileAppender to ...

        • RandomAccessFileRollingAppender?
        • RandomAccessRollingFileAppender?
        • RollingRandomAccessFileAppender?
        Show
        Remko Popma added a comment - Tricky to find a good name for the rolling version: rename FastRollingFileAppender to ... RandomAccessFileRollingAppender? RandomAccessRollingFileAppender? RollingRandomAccessFileAppender?
        Hide
        Remko Popma added a comment -

        These make for some really wacky acronyms too: RAFRA! RARFA! RollRAFAp! (Sorry, couldn't resist...)

        Show
        Remko Popma added a comment - These make for some really wacky acronyms too: RAFRA! RARFA! RollRAFAp! (Sorry, couldn't resist...)
        Hide
        Gary Gregory added a comment -

        I would just prepend RandomAccessFileAppender to get RollingRandomAccessFileAppender

        Show
        Gary Gregory added a comment - I would just prepend RandomAccessFileAppender to get RollingRandomAccessFileAppender
        Hide
        Gary Gregory added a comment -
        commit -m "[LOG4J2-317] Rename FastFileAppender and FastRollingFileAppender to RandomAccessFileAppender and RollingRandomAccessFileAppender." (51 paths specified)
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/FastFileAppender.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/FastFileManager.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/FastRollingFileAppender.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppender.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileManager.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FastRollingFileManager.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/async/AsyncLogger.java
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastFileAppenderLocationTest.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastFileAppenderTest.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastFileManagerTest.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastRollingFileAppenderLocationTest.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastRollingFileAppenderRolloverTest.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastRollingFileAppenderTest.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastXmlFileAppenderTest.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppenderLocationTest.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppenderTest.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RandomAccessFileManagerTest.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderLocationTest.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderRolloverTest.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderTest.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/XmlRandomAccessFileAppenderTest.java
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/rolling/FastRollingFileManagerTest.java
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManagerTest.java
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/AsyncLoggerLocationTest.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/AsyncLoggerTest.xml
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastFileAppenderLocationTest.xml
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastFileAppenderTest.xml
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastRollingFileAppenderLocationTest.xml
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastRollingFileAppenderTest.xml
            Deleting       C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastXmlFileAppenderTest.xml
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/RandomAccessFileAppenderLocationTest.xml
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/RandomAccessFileAppenderTest.xml
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/RollingRandomAccessFileAppenderLocationTest.xml
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/RollingRandomAccessFileAppenderTest.xml
            Adding         C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/XmlRandomAccessFileAppenderTest.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/src/changes/changes.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/src/site/site.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/src/site/xdoc/manual/appenders.xml
            Sending        C:/vcs/svn/apache/log4j2/trunk/src/site/xdoc/manual/async.xml
            Transmitting file data ...
            Committed revision 1508130.
        
        Show
        Gary Gregory added a comment - commit -m "[LOG4J2-317] Rename FastFileAppender and FastRollingFileAppender to RandomAccessFileAppender and RollingRandomAccessFileAppender." (51 paths specified) Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/FastFileAppender.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/FastFileManager.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/FastRollingFileAppender.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppender.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileManager.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FastRollingFileManager.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java Sending C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/async/AsyncLogger.java Sending C:/vcs/svn/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastFileAppenderLocationTest.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastFileAppenderTest.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastFileManagerTest.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastRollingFileAppenderLocationTest.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastRollingFileAppenderRolloverTest.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastRollingFileAppenderTest.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/FastXmlFileAppenderTest.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppenderLocationTest.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppenderTest.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RandomAccessFileManagerTest.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderLocationTest.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderRolloverTest.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderTest.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/XmlRandomAccessFileAppenderTest.java Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/rolling/FastRollingFileManagerTest.java Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManagerTest.java Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/AsyncLoggerLocationTest.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/AsyncLoggerTest.xml Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastFileAppenderLocationTest.xml Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastFileAppenderTest.xml Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastRollingFileAppenderLocationTest.xml Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastRollingFileAppenderTest.xml Deleting C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/FastXmlFileAppenderTest.xml Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/RandomAccessFileAppenderLocationTest.xml Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/RandomAccessFileAppenderTest.xml Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/RollingRandomAccessFileAppenderLocationTest.xml Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/RollingRandomAccessFileAppenderTest.xml Adding C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/XmlRandomAccessFileAppenderTest.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml Sending C:/vcs/svn/apache/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml Sending C:/vcs/svn/apache/log4j2/trunk/src/changes/changes.xml Sending C:/vcs/svn/apache/log4j2/trunk/src/site/site.xml Sending C:/vcs/svn/apache/log4j2/trunk/src/site/xdoc/manual/appenders.xml Sending C:/vcs/svn/apache/log4j2/trunk/src/site/xdoc/manual/async.xml Transmitting file data ... Committed revision 1508130.

          People

          • Assignee:
            Gary Gregory
            Reporter:
            Remko Popma
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development