[LOG4J2-2916] If loggercontext got reconfigured and kafka appender got recreated, the previous producer can not be closed, which cause thread leak

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Assignee: Volkan Yazici
• Reporter: wuqian
• Created: 25/Aug/20 04:00
• Updated: 12/Nov/20 22:15
• Resolved: 12/Nov/20 22:15

Description

If loggercontext got reconfigured and kafka appender got recreated, the previous kafka producer thread can not be closed, which cause thread leak

 

Repeat steps:

xml configured to use kafka appender

LoggerContext.getContext(false).reconfigure();
LoggerContext.getContext(false).reconfigure();
LoggerContext.getContext(false).reconfigure();
LoggerContext.getContext(false).reconfigure();
LoggerContext.getContext(false).reconfigure();
LoggerContext.getContext(false).reconfigure();
LoggerContext.getContext(false).reconfigure();
LoggerContext.getContext(false).reconfigure();

 

Resolution:

In case the abstractlogmanager always cache the latest new producer and old producer can not be released.

When creating new kafkamanager, add a logic to release previous kafka producer.

 

public void startup() {
// If loggercontext reconfigured and kafka appender got recreated, the previous producer can not be closed
// which cause thread leak
if(producer != null)

{ producer.close(); }

producer = producerFactory.newKafkaProducer(config);
}

 

Issue Links

• links to: GitHub Pull Request #426
• links to: GitHub Pull Request #428