[LOG4J2-277] Wasted work in RollingAppenderSizeTest.testAppender() and other tests

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0-beta7
• Fix Version/s: 2.0-beta8
• Labels: patch performance

Environment

any

• Assignee: Unassigned
• Reporter: Adrian Nistor
• Created: 10/Jun/13 15:15
• Updated: 13/Jun/13 23:24
• Resolved: 13/Jun/13 23:24

Description

The problem appears in Log4j 2.0-beta7 and in revision 1491481. I
attached a one-line patch (patch.diff) that fixes it. This problem
and the attached patch are similar to the previously fixed LOG4J2-273
and LOG4J2-274, and their patches.

In method "RollingAppenderSizeTest.testAppender", the loop over
"files" should break immediately after "found" is set to "true". All
the iterations after "found" is set to "true" do not perform any
useful work, at best they just set "found" again to "true".

Similar problems exist in
"RollingAppenderTimeAndSizeTest.testAppender",
"RollingAppenderTimeTest.testAppender",
"RollingAppenderUncompressedTest.testAppender", "PerfTest.doMain", and
"AdvertiserTest.verifyExpectedEntriesAdvertised". I attached patches
patch2.diff, patch3.diff, patch4.diff, patch5.diff, and patch6.diff
for these methods. I also attached a patch (patchAll.diff) that
aggregates all these changes in one single patch.