[LOG4J2-2693] @PluginValue does not support attribute names besides "value"

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.12.1
• Fix Version/s: 3.0.0, 2.13.0
• Component/s: Plugins
• Epic Link: Plugin Ergonomics
• Assignee: Matt Sicker
• Reporter: Matt Sicker
• Created: 15/Sep/19 18:56
• Updated: 06/Oct/19 21:28
• Resolved: 06/Oct/19 20:25

Description

While working in the plugin system recently, I discovered an inconsistent behavior in how @PluginValue works compared to @PluginAttribute. If a value is specified other than "value", then I'd expect that the contents of that value to be the attribute name in the configuration file.

For example:

@Plugin(name = "Foo", category = "Core", ...)
public class Foo {
// ...
@PluginFactory
public static Foo createFoo(@PluginValue("bar") String bar) {
  return new Foo(bar);
}
}

Expected XML config:

<Foo bar="baz"/>

Actual XML config:

<Foo value="baz"/>

Issue Links

• causes: LOG4J2-2647 Validation blocks definition of script in properties configuration