[LOG4J2-2674] CompositeConfiguration misleading configuration source

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.8.1
• Fix Version/s: 2.13.0
• Component/s: Core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Anton Korenkov
• Created: 14/Aug/19 13:43
• Updated: 07/Dec/19 05:00
• Resolved: 07/Dec/19 05:00

Description

Sometimes we are using CompositeConfiguration in our code. During last investigation we've found out that configuration source passed during constructor call is 'NULL_SOURCE'. It's a bit confusing because it conflicts with NULL_SOURCE definition

    /**
     * ConfigurationSource to use with Configurations that do not require a "real" configuration source.
     */
    public static final ConfigurationSource NULL_SOURCE = new ConfigurationSource(new byte[0]);

because actually we have a 'composite' or 'multiple' configuration sources which will be used later to produce real configuration.

The question is: do you mind to create 'COMPOSITE_SOURCE' constant and use it in CompositeConfiguration?

Issue Links

• links to: GitHub Pull Request #302