[LOG4J2-2417] Better handling of optional properties

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Log4j-Audit 1.0.0
• Fix Version/s: Log4j-Audit 1.0.1
• Component/s: Log4j-Audit
• Assignee: Ralph Goers
• Reporter: Andrei Ivanov
• Created: 22/Aug/18 07:45
• Updated: 22/Sep/18 06:36
• Resolved: 22/Sep/18 06:24

Description

The Log4j-Audit project page indicates this as the place to file tickets, but I don't see the 1.0.0 version for it.

Investigating the use of the project, I started with a basic `catalog.json`, with just an event and 2 attributes, both with requestContext = false.

java.lang.NullPointerException
	at org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
	at org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
	at org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
	at org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)

As far as I understand, request context attributes are not required.
While usage of a RequestContext is not required, the use of one should be considered a best practice.

Also, AFAIU, the event attributes should also be optional, there's even a test event login like that.

Also the code seems to indicate that @MaxLength should also be optional, same as @RequestContext.

Issue Links

• links to: GitHub Pull Request #7