Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-211

"entry" and "exit" messages prepended with extra space, spaces not consistent between entry and exit

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta5
    • Fix Version/s: 2.0-beta5
    • Component/s: API
    • Labels:
      None

      Description

      Lines 386 and 388 of AbstractLogger introduce an unnecessary space before the entry message (e.g., " entry"). Lines 1407 and 1409 of AbstractLogger introduce an unnecessary space before the exit message (e.g., " exit"). These spaces need to be removed. The "catching" and "throwing" messages do not contain a space before them, nor would one normally log a message starting with a space.

      Line 388 DOES NOT have a space between "parms" and the opening parenthesis, but line 1409 DOES have a space between "with" and the opening parenthesis. This is inconsistent. I would argue for removing the space on line 1409 between "with" and the opening parenthesis ... looks better.

      (NOTE: A patch proposed on LOG4J2-187 tonight adds unit tests, a handful of which will fail if the above proposed changes are made. Keep that in mind when making this change after committing those tests, or when committing those tests after making this change.)

        Attachments

          Activity

            People

            • Assignee:
              ralph.goers@dslextreme.com Ralph Goers
              Reporter:
              beamerblvd Nick Williams
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.25h
                0.25h
                Remaining:
                Remaining Estimate - 0.25h
                0.25h
                Logged:
                Time Spent - Not Specified
                Not Specified