Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-201

Having 'type' and 'elementType' on plugin is confusing

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-beta6
    • Component/s: None
    • Labels:
      None

      Description

      Type isn't a very descriptive name for a plugin attribute, and elementType isn't much better. The two of them together lead to confusion.

      Are there better names we can use?

      The list of 'types' include core, converter, fileconverter (slightly confusing), configurationfactory, lookup and keyprovider...

      The list of 'elementTypes' is larger, and includes appender, layout, advertiser, etc...

      It would be great if we could find another name for one of these..preferably 'type'...how about...category??

        Activity

        Hide
        ralph.goers@dslextreme.com Ralph Goers added a comment -

        Renamed Plugin annotation attribute "type" to "category" in revision 1479232. Please verify and close.

        Show
        ralph.goers@dslextreme.com Ralph Goers added a comment - Renamed Plugin annotation attribute "type" to "category" in revision 1479232. Please verify and close.
        Hide
        ralph.goers@dslextreme.com Ralph Goers added a comment -

        I agree that they are confusing. I would suggest "group". "category" would be OK too.

        Show
        ralph.goers@dslextreme.com Ralph Goers added a comment - I agree that they are confusing. I would suggest "group". "category" would be OK too.

          People

          • Assignee:
            ralph.goers@dslextreme.com Ralph Goers
            Reporter:
            sdeboy Scott Deboy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development