[LOG4J2-1591] New method on LifeCycle interface breaks binary compatibility

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 2.7
• Assignee: Remko Popma
• Reporter: Remko Popma
• Created: 17/Sep/16 14:35
• Updated: 18/Sep/16 13:13
• Resolved: 18/Sep/16 13:13

Description

https://issues.apache.org/jira/browse/LOG4J2-1539 introduced method stop(long, TimeUnit).

LifeCycle is a top level interface extended by Appender, Configuration, Filter and Filterable. This change will break implementations that don't extend our abstract classes.

We should pull the new method out into a new LifeCycle2 extends LifeCycle interface. Our abstract super classes would all implement the new interface.

In places where we are given a LifeCycle object and want to invoke the new method we first need to check that it implements LifeCycle2. If it doesn't, our code should probably call the existing stop() method so that existing custom user code continues to work.

Issue Links

• is broken by: LOG4J2-1539 Add Core API Configurator.shutdown(LoggerContext, long, TimeUnit)
• relates to: LOG4J2-1576 Better automated backwards compatibility checking