Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-1350

Circuit Breaker for log system to avoid DOS by recursion

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: Core
    • Labels:
      None

      Description

      We have encountered the following situation: A method in an application thread was recursively calling itself again and again, until the inevitable StackOverflowException occurred. Other application threads worked fine, but since we use asynchronous logging, the Log4j ring buffer ran full because of the thread that was running amok. As a consequence none of the other threads could issue any log messages any more.

      In production systems we MUST be able to see log messages, otherwise we have hardly a means to tell when something goes wrong and to discover problems like this.

      So my suggestion would be to add a circuit breaker pattern to the Log4j core system (unless there already is one that I'm not aware of), that would track the frequency of log events per thread and open once a dangerous threshold has been reached or exceeded. That way other threads would still be able to send log events once the ring buffer is free again.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                SteffenO Steffen Offermann
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: