[LOG4J2-1333] MarkerManager getMarker methods should avoid creating temporary objects

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.6
• Component/s: API
• Epic Link: GC-free
• Assignee: Remko Popma
• Reporter: Remko Popma
• Created: 27/Mar/16 05:36
• Updated: 27/Mar/16 05:43
• Resolved: 27/Mar/16 05:43

Description

Currently MarkerManager's get methods create a new Marker object for each invocation.

I propose to change this as follows:

// current
public static Marker getMarker(final String name) {
    MARKERS.putIfAbsent(name, new Log4jMarker(name));
    return MARKERS.get(name);
}

// proposed
public static Marker getMarker(final String name) {
    Marker result = MARKERS.get(name);
    if (result == null) {
        MARKERS.putIfAbsent(name, new Log4jMarker(name));
        result = MARKERS.get(name);
    }
    return result;
}