[LOG4J2-1260] TlsSyslogFrame calculates message length incorrectly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.6
• Component/s: Layouts
• Assignee: Gary D. Gregory
• Reporter: Gary D. Gregory
• Created: 21/Jan/16 17:58
• Updated: 21/Jan/16 22:43
• Resolved: 21/Jan/16 22:43

Description

TlsSyslogFrame calculates message length incorrectly.

From the ML https://www.mail-archive.com/[e-mail]/msg15386.html

---------- Forwarded message ----------
From: Blake Day <[e-mail]>
Date: Wed, Jan 20, 2016 at 4:58 PM
Subject: TlsSyslogFrame calculates message length incorrectly
To: Log4J Users List <[e-mail]>

TlsSyslogFrame appears to be miscalculating the message length. According to RFC5425, the message length must be the octet count of the SYSLOG-MSG in the frame. Though the variable below is aptly named messageLengthInBytes, it is assigned the value from message.length() (where message is a String) rather than the bytes.

See below for relevant portions of code:

private String message;
private int messageLengthInBytes;

private void setLengthInBytes() {
messageLengthInBytes = message.length();
}

@Override
public String toString() {
final String length = Integer.toString(messageLengthInBytes);
return length + Chars.SPACE + message;
}