Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-1121

LoggerConfig performance improvement: remove waitForCompletion and associated fields

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Core
    • Labels:
      None

      Description

      This ticket follows up on LOG4J2-1120. Out of the three changes identified in LOG4J2-1120, only two could be implemented in time for the 2.4 release.

      This ticket tracks the remaining work for the third change:

      • Since clearAppenders() is only called after all appenders have been stopped, waitForCompletion() may no longer be necessary (unless I am missing something here). If so, the shutdownLock, shutdown and counter fields can be removed. Not incrementing the atomic counters with every event in the hot path should give better performance.

      LOG4J2-1120 shows benchmark results that support this.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              rpopma Remko Popma
              Reporter:
              rpopma Remko Popma

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment