[LOG4J2-1102] Follow up: remaining tasks related to introducing FastDateFormat

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.3
• Component/s: Pattern Converters
• Assignee: Unassigned
• Reporter: Remko Popma
• Created: 22/Aug/15 13:30
• Updated: 11/Jul/16 07:32

Description

The main goal of LOG4J2-812 (improve performance by replacing synchronized SimpleDateFormat with Apache Commons FastDateFormat) has been achieved. This ticket is to track some remaining work Gary identified to do some final polishing.

• Make comments like "Copied from Commons Lang 3" more specific, for example: "Copied from Commons Lang 3.4 tag http://..." or "Copied from Commons Lang 3.4 Git revision xxx". This will allow maintainers to know when it might make sense to look for updating the code from Commons Lang again.
• Pick up the latest sources from Apache Commons Lang for FastDate classes and document per above. I propose we document provenance next to the sources in the package, in a package comment, this would let the only change be in the package decl. The less fiddling the better.

Issue Links

• relates to: LOG4J2-812 Performance optimization: avoid use of synchronized SimpleDateFormat in Dat​ePatternCo​nverter
• relates to: LOG4J2-1279 NullPointerException in FastDateParser$TimeZoneStrategy