Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-728

SSLError missing from @retry exceptions

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Core
    • Labels:

      Description

      In libcloud/utils/misc.py, the retry decorator is supposed to retry functions upon encountering transient network failures. However, the list of exceptions is missing ssl.SSLError, which can be thrown when attempting to connect over HTTPS.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user thesquelched opened a pull request:

        https://github.com/apache/libcloud/pull/556

        LIBCLOUD-728 Add SSLError to retry decorator exceptions

        Add `ssl.SSLError` to the list of exceptions that `libcloud.utils.misc.retry` catches, since that `SSLError` can be a transient error. Also:

        • Clean up `retry` a bit, fixing an issue in which keyword arguments defaults are not applied
        • Enable retries in tests that are designed to test retries (previous, some tests passed trivially)

        See: https://issues.apache.org/jira/browse/LIBCLOUD-728

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/thesquelched/libcloud retry_ssl_error

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/libcloud/pull/556.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #556


        commit 1499f11920f9f620041207b212c3216781029382
        Author: Scott Kruger <scott.kruger@rackspace.com>
        Date: 2015-07-30T15:02:31Z

        LIBCLOUD-728 Add SSLError to retry decorator exceptions


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user thesquelched opened a pull request: https://github.com/apache/libcloud/pull/556 LIBCLOUD-728 Add SSLError to retry decorator exceptions Add `ssl.SSLError` to the list of exceptions that `libcloud.utils.misc.retry` catches, since that `SSLError` can be a transient error. Also: Clean up `retry` a bit, fixing an issue in which keyword arguments defaults are not applied Enable retries in tests that are designed to test retries (previous, some tests passed trivially) See: https://issues.apache.org/jira/browse/LIBCLOUD-728 You can merge this pull request into a Git repository by running: $ git pull https://github.com/thesquelched/libcloud retry_ssl_error Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #556 commit 1499f11920f9f620041207b212c3216781029382 Author: Scott Kruger <scott.kruger@rackspace.com> Date: 2015-07-30T15:02:31Z LIBCLOUD-728 Add SSLError to retry decorator exceptions
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/libcloud/pull/556

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/556

          People

          • Assignee:
            Unassigned
            Reporter:
            thesquelched Scott Kruger
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development