Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-723

Azure driver - wait_until_running function is broken

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Compute
    • Labels:
      None

      Description

      In the Azure compute driver, the wait_until_running method inherited from the base compute module is broken. The method calls self.list_nodes() with no options, but the Azure driver's list_nodes method requires ex_cloud_service parameter, so an exception is thrown.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user davidwilson2038 opened a pull request:

        https://github.com/apache/libcloud/pull/548

        LIBCLOUD-723 Added cloud specific parameter to base compute wait_un…

        Fixed LIBCLOUD-723 bug with Azure driver where the wait_until_running method is broken because it calls self.list_nodes() without any options (list_nodes is defined as requiring an ex_cloud_service parameter). I added an optional ex_cloud_opts parameter to the wait_until_running method to make it work and also allow users of other drivers to specify additional configuration parameters if their list_nodes function allows.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/davidwilson2038/libcloud LIBCLOUD-723_bugfix

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/libcloud/pull/548.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #548


        commit 992ae44bbb0b0a65dfc7f79f78d5e9e85917eafe
        Author: dwilson2038 <david.wilson2038@gmail.com>
        Date: 2015-07-17T14:16:29Z

        LIBCLOUD-723 Added cloud specific parameter to base compute wait_until_running method to make compatible with Azure


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user davidwilson2038 opened a pull request: https://github.com/apache/libcloud/pull/548 LIBCLOUD-723 Added cloud specific parameter to base compute wait_un… Fixed LIBCLOUD-723 bug with Azure driver where the wait_until_running method is broken because it calls self.list_nodes() without any options (list_nodes is defined as requiring an ex_cloud_service parameter). I added an optional ex_cloud_opts parameter to the wait_until_running method to make it work and also allow users of other drivers to specify additional configuration parameters if their list_nodes function allows. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davidwilson2038/libcloud LIBCLOUD-723 _bugfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/548.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #548 commit 992ae44bbb0b0a65dfc7f79f78d5e9e85917eafe Author: dwilson2038 <david.wilson2038@gmail.com> Date: 2015-07-17T14:16:29Z LIBCLOUD-723 Added cloud specific parameter to base compute wait_until_running method to make compatible with Azure
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/libcloud/pull/548

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/548

          People

          • Assignee:
            Unassigned
            Reporter:
            dwilson2038 David Wilson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development