Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-690

EC2: create_node ignores errors in ex_create_tags

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Compute
    • Labels:
      None

      Description

      This was introduced in 796f6f2c (Wrap ex_create_tags call inside create_node in a try / except block and for now ignore tag creation errors.). If the intent was that the call should not abort after the original RunInstance request finished successfully, failure to create the tags should at least be indicated by not updating node.extra['tags'].
      I would argue though that potentially ignoring the name and ex_metadata parameters puts a lot of uncertainty in this method.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                sfriesel Stefan Friesel
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: