[LIBCLOUD-664] EC2 driver breaks contract with base driver in `list_volume_snapshots`

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Allard Hoeve
• Created: 12/Feb/15 13:30
• Updated: 20/Feb/15 20:19

Description

The base driver has the following definition for `list_volume_snapshots`:

def list_volume_snapshots(self, volume):
        """
        List snapshots for a storage volume.
        
        :rtype: ``list`` of :class:`VolumeSnapshot`
        """
        raise NotImplementedError(
            'list_volume_snapshots not implemented for this driver')

This function is volume-centric and should return all snapshots for the given Volume.

In contrast, EC2 has the following, which is snapshot-centric and returns only the given snapshot.

    def list_volume_snapshots(self, snapshot):
        return self.list_snapshots(snapshot)

We should change this to both be volume-centric. In its current form, this function is identical to list_snapshots and thus redundant.