Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-569

RimuhostingResponseClass is unnecessarily overloaded.

    Details

    • Type: Bug
    • Status: Open
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: 0.14.0-beta3
    • Fix Version/s: None
    • Component/s: Compute
    • Labels:
    • Environment:

      Tested on Mac OSX and Ubuntu 13.10 using libcloud 0.14.1

      Description

      Response not decompressed due to no call to response base class constructor. What the Rimu response class is doing already occurs in the base class.

      Patch is inbound.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user amastracci opened a pull request:

        https://github.com/apache/libcloud/pull/303

        LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting ...

        ...base class.

        Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/Pertino/libcloud trunk

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/libcloud/pull/303.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #303


        commit feb5a8e85012ea9f78f9baf8455a154a49430a63
        Author: amastracci <amastracci@pertino.com>
        Date: 2014-06-01T19:22:28Z

        LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting base class.

        Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user amastracci opened a pull request: https://github.com/apache/libcloud/pull/303 LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting ... ...base class. Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Pertino/libcloud trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #303 commit feb5a8e85012ea9f78f9baf8455a154a49430a63 Author: amastracci <amastracci@pertino.com> Date: 2014-06-01T19:22:28Z LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting base class. Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user amastracci closed the pull request at:

        https://github.com/apache/libcloud/pull/303

        Show
        githubbot ASF GitHub Bot added a comment - Github user amastracci closed the pull request at: https://github.com/apache/libcloud/pull/303
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user amastracci reopened a pull request:

        https://github.com/apache/libcloud/pull/303

        LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting ...

        ...base class.

        Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/Pertino/libcloud trunk

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/libcloud/pull/303.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #303


        commit feb5a8e85012ea9f78f9baf8455a154a49430a63
        Author: amastracci <amastracci@pertino.com>
        Date: 2014-06-01T19:22:28Z

        LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting base class.

        Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user amastracci reopened a pull request: https://github.com/apache/libcloud/pull/303 LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting ... ...base class. Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Pertino/libcloud trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #303 commit feb5a8e85012ea9f78f9baf8455a154a49430a63 Author: amastracci <amastracci@pertino.com> Date: 2014-06-01T19:22:28Z LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting base class. Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dff5c5314790968fa1bdebf66d8b83dae4e64201 in libcloud's branch refs/heads/trunk from amastracci
        [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=dff5c53 ]

        LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting base class.

        Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.

        Closes #303

        Signed-off-by: Tomaz Muraus <tomaz@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit dff5c5314790968fa1bdebf66d8b83dae4e64201 in libcloud's branch refs/heads/trunk from amastracci [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=dff5c53 ] LIBCLOUD-569 Removing the overloaded constructor from the rimuhosting base class. Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase. Closes #303 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/libcloud/pull/303

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/303

          People

          • Assignee:
            Unassigned
            Reporter:
            ddoberloh dustin oberloh
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development