Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-430

Support content-disposition header

        Details

        • Type: New Feature
        • Status: Open
        • Priority: Major
        • Resolution: Unresolved
        • Affects Version/s: 0.13.2
        • Fix Version/s: None
        • Component/s: Storage
        • Labels:
          None

          Description

          Implement functionality to be able to support sending the Content-Disposition header with stored files. This allows them to have flags set allowing their original filename to be preserved when downloaded from a CDN, and suggest to the browser that the file should be saved to disk rather than displayed.

          I've implemented this in https://github.com/Caramel/libcloud/commit/181ed20, however it also included an initial workaround for the problem I've separately reported in LIBCLOUD-429.

          1. Text File
            libcloud430.patch
            1 kB
            Michael Farrell

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            kami Tomaz Muraus added a comment -

            Sorry for the delay, looks like I've missed your comment.

            In any case, I've merged your patch into trunk. Thanks!

            Next time please use git format-patch when creating a patch so we can preserve the commit author (this time I generated a patch based on your Github pull request).

            Show
            kami Tomaz Muraus added a comment - Sorry for the delay, looks like I've missed your comment. In any case, I've merged your patch into trunk. Thanks! Next time please use git format-patch when creating a patch so we can preserve the commit author (this time I generated a patch based on your Github pull request).
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 7b3fd341a5dcf5ce2d313e8a20ec7b9177f5c727 in branch refs/heads/trunk from Michael Farrell
            [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=7b3fd34 ]

            LIBCLOUD-430: Implement support for content-disposition header in the CloudFiles driver.

            Signed-off-by: Tomaz Muraus <tomaz@apache.org>

            Show
            jira-bot ASF subversion and git services added a comment - Commit 7b3fd341a5dcf5ce2d313e8a20ec7b9177f5c727 in branch refs/heads/trunk from Michael Farrell [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=7b3fd34 ] LIBCLOUD-430 : Implement support for content-disposition header in the CloudFiles driver. Signed-off-by: Tomaz Muraus <tomaz@apache.org>
            Hide
            Permalink
            micolous Michael Farrell added a comment -

            Updated patch to take into account the comment on the GitHub commit.

            Show
            micolous Michael Farrell added a comment - Updated patch to take into account the comment on the GitHub commit.
            Hide
            Permalink
            micolous Michael Farrell added a comment -

            Cherry-picked patch for LIBCLOUD-430.

            Show
            micolous Michael Farrell added a comment - Cherry-picked patch for LIBCLOUD-430 .
            Hide
            Permalink
            kami Tomaz Muraus added a comment -

            Looks good. Please attach a patch with just this change to this ticket and I'll merge it into trunk.

            Thanks!

            Show
            kami Tomaz Muraus added a comment - Looks good. Please attach a patch with just this change to this ticket and I'll merge it into trunk. Thanks!

              People

              • Assignee:
                Unassigned
                Reporter:
                micolous Michael Farrell
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Development