Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.2
    • Fix Version/s: 0.12.1
    • Component/s: Compute
    • Labels:
    • Environment:

      Problem has been noticed by several users running salt-cloud, across CentOS 6.3, Ubuntu 12.10 and the current Arch Linux. Issue is EC2-specific.

      Description

      The list_images() function has no way to pass a list of images to EC2's DescribeImages Action. This means that DescribeImages will always return every image that EC2 knows about, which numbers in the several hundreds. In salt-cloud, this causes the CPU and memory to get pegged every time this call is made:

      https://github.com/saltstack/salt-cloud/issues/100
      https://github.com/saltstack/salt-cloud/issues/197

      After patching it in my local copy of the repo, I discovered that a pull req had already been submitted which does a much better job at fixing the issue than I did:

      https://github.com/apache/libcloud/pull/77

      If that pull req were to be merged, it would help out a lot.

        Activity

        Hide
        kami Tomaz Muraus added a comment -

        Thanks.

        I'll have a look at the existing pull request. I haven't noticed it sooner, because it was submitted through an unofficial channel and in the past we didn't receive notifications if someone opened a pull request on Github.

        Show
        kami Tomaz Muraus added a comment - Thanks. I'll have a look at the existing pull request. I haven't noticed it sooner, because it was submitted through an unofficial channel and in the past we didn't receive notifications if someone opened a pull request on Github.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1443458 from Tomaz Muraus
        [ https://svn.apache.org/r1443458 ]

        Allow users to filter images returned by the list_images method in the EC2
        driver by providing ex_image_ids argument.

        Contributed by Chris Psaltis, part of LIBCLOUD-294.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1443458 from Tomaz Muraus [ https://svn.apache.org/r1443458 ] Allow users to filter images returned by the list_images method in the EC2 driver by providing ex_image_ids argument. Contributed by Chris Psaltis, part of LIBCLOUD-294 .
        Hide
        kami Tomaz Muraus added a comment -

        I've fixed a broken test in the GITHUB-77 pull request and merged it into trunk.

        Thanks.

        Show
        kami Tomaz Muraus added a comment - I've fixed a broken test in the GITHUB-77 pull request and merged it into trunk. Thanks.
        Hide
        kami Tomaz Muraus added a comment - - edited

        On a side note, we should probably consider adding a generator version of all the list methods where this makes sense. Similar to what Mahendra M did in DNS drivers recently.

        This would help with the memory issue.

        Show
        kami Tomaz Muraus added a comment - - edited On a side note, we should probably consider adding a generator version of all the list methods where this makes sense. Similar to what Mahendra M did in DNS drivers recently. This would help with the memory issue.
        Hide
        techhat Joseph Hall added a comment -

        This alone will help with the memory issue, and speed things up dramatically. If there was a generator version, I would likely make use of it as well.

        Thanks for this, Tomaz!

        Show
        techhat Joseph Hall added a comment - This alone will help with the memory issue, and speed things up dramatically. If there was a generator version, I would likely make use of it as well. Thanks for this, Tomaz!

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            techhat Joseph Hall
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development