Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-291

Deletion of an image for IBM sce driver

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.2
    • Fix Version/s: 0.12.1
    • Component/s: Compute, Libcloud REST
    • Labels:
      None

      Description

      Delete image is the functionality provided by IBM SCE. The patch is to provide image deletion feature for IBM SCE.

        Activity

        Hide
        kami Tomaz Muraus added a comment -

        Thanks. I've merged your patch into trunk with some fixes.

        After applying your patch the IBM SCE tests failed. There were two issues:

        • mixing tabs and spaces
        • invalid name of the mock http method for returning destroy_image.xml response

        ======================================================================
        ERROR: test_ex_destroy_image (libcloud.test.compute.test_ibm_sce.IBMTests)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
        File "/w/lc/trunk/libcloud/test/compute/test_ibm_sce.py", line 194, in test_ex_destroy_image
        ret = self.driver.ex_destroy_image(image[0])
        File "/w/lc/trunk/libcloud/compute/drivers/ibm_sce.py", line 361, in ex_destroy_image
        method='DELETE').status)
        File "/w/lc/trunk/libcloud/common/base.py", line 600, in request
        headers=headers)
        File "/w/lc/trunk/libcloud/test/_init_.py", line 172, in request
        meth = getattr(self, meth_name.replace('%', '_'))
        AttributeError: 'IBMMockHttp' object has no attribute '_computecloud_enterprise_api_rest_20100331_offerings_image_2_DESTROY'

        Next time before submitting a patch please make sure the tests pass.

        Show
        kami Tomaz Muraus added a comment - Thanks. I've merged your patch into trunk with some fixes. After applying your patch the IBM SCE tests failed. There were two issues: mixing tabs and spaces invalid name of the mock http method for returning destroy_image.xml response ====================================================================== ERROR: test_ex_destroy_image (libcloud.test.compute.test_ibm_sce.IBMTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/w/lc/trunk/libcloud/test/compute/test_ibm_sce.py", line 194, in test_ex_destroy_image ret = self.driver.ex_destroy_image(image [0] ) File "/w/lc/trunk/libcloud/compute/drivers/ibm_sce.py", line 361, in ex_destroy_image method='DELETE').status) File "/w/lc/trunk/libcloud/common/base.py", line 600, in request headers=headers) File "/w/lc/trunk/libcloud/test/_ init _.py", line 172, in request meth = getattr(self, meth_name.replace('%', '_')) AttributeError: 'IBMMockHttp' object has no attribute '_computecloud_enterprise_api_rest_20100331_offerings_image_2_DESTROY' Next time before submitting a patch please make sure the tests pass.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1443019 from Tomaz Muraus
        [ https://svn.apache.org/r1443019 ]

        Add ex_destroy_image method to IBM SCE driver.

        Contributed by Perry Zou part of LIBCLOUD-291.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1443019 from Tomaz Muraus [ https://svn.apache.org/r1443019 ] Add ex_destroy_image method to IBM SCE driver. Contributed by Perry Zou part of LIBCLOUD-291 .
        Hide
        perryzou Perry Zou added a comment -

        The attached file is to provide deletion function provided by IBM SCE.

        Show
        perryzou Perry Zou added a comment - The attached file is to provide deletion function provided by IBM SCE.

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            perryzou Perry Zou
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development