Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-260

Added support for service_region to Cloudfiles driver

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.11.2
    • Fix Version/s: 0.11.2
    • Component/s: Storage
    • Labels:
      None
    • Environment:

      0.11.x

      Description

      I added support for passing in ex_force_service_region for the Cloudfiles driver. Do you think I should change it to use get_endpoint instead?

        Activity

        Hide
        dispalt Dan Di Spaltro added a comment -

        Here's the patch.

        Show
        dispalt Dan Di Spaltro added a comment - Here's the patch.
        Hide
        kami Tomaz Muraus added a comment -

        Thanks, I've merged your patch into 0.11.x branch - http://svn.apache.org/viewvc?view=revision&revision=r1410810.

        I don't plan to merge it into trunk, because I plan to get rid of all those ex_ arguments in the CloudFiles driver and make it easier and less confusing to use (similar to changes I've made in the Rackspace compute driver).

        Show
        kami Tomaz Muraus added a comment - Thanks, I've merged your patch into 0.11.x branch - http://svn.apache.org/viewvc?view=revision&revision=r1410810 . I don't plan to merge it into trunk, because I plan to get rid of all those ex_ arguments in the CloudFiles driver and make it easier and less confusing to use (similar to changes I've made in the Rackspace compute driver).
        Hide
        acdha Chris Adams added a comment -

        Is there a plan to ship a fix for the 0.12 branch soon? I just upgraded to the latest release on PyPI (0.12.3) and was surprised to see my files going to DFW again.

        Show
        acdha Chris Adams added a comment - Is there a plan to ship a fix for the 0.12 branch soon? I just upgraded to the latest release on PyPI (0.12.3) and was surprised to see my files going to DFW again.
        Hide
        kami Tomaz Muraus added a comment - - edited

        Chris Adams this patch should be available on 0.12.x. If it's not it's a regression.

        Edit: You are right. I just checked it out and this patch is not present in 0.12.x. It's a regression, I will work on getting a bug fix committed and shipped asap.

        Show
        kami Tomaz Muraus added a comment - - edited Chris Adams this patch should be available on 0.12.x. If it's not it's a regression. Edit: You are right. I just checked it out and this patch is not present in 0.12.x. It's a regression, I will work on getting a bug fix committed and shipped asap.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1468530 from Tomaz Muraus
        [ https://svn.apache.org/r1468530 ]

        Fix a regression with removed ex_force_service_region constructor kwarg in
        the CloudFiles driver.

        Part of LIBCLOUD-260.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1468530 from Tomaz Muraus [ https://svn.apache.org/r1468530 ] Fix a regression with removed ex_force_service_region constructor kwarg in the CloudFiles driver. Part of LIBCLOUD-260 .
        Hide
        acdha Chris Adams added a comment -

        Thanks for the very rapid fix!

        Show
        acdha Chris Adams added a comment - Thanks for the very rapid fix!
        Hide
        kami Tomaz Muraus added a comment -

        No problem.

        I will start a vote thread for a new release in 0.12.x branch with this bug-fix as soon as possible.

        Show
        kami Tomaz Muraus added a comment - No problem. I will start a vote thread for a new release in 0.12.x branch with this bug-fix as soon as possible.

          People

          • Assignee:
            Unassigned
            Reporter:
            dispalt Dan Di Spaltro
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development