Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-225

Gandi driver improvment to use new volume methods

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      Gandi platform use block device volumes to be managed with nodes. There was specific methods to deal with disks previously and they can be replaced to new base libcloud volume object and methods.

      By the way I changed the API endpoint to a more suitable one.

      1. LIBCLOUD-225-svn.patch
        20 kB
        Aymeric Barantal
      2. LIBCLOUD-225.patch
        25 kB
        Aymeric Barantal

        Activity

        Hide
        mric Aymeric Barantal added a comment -

        1 commit for change of API endpoint, 4 for upgrade to volumes* methods with unit tests.

        Show
        mric Aymeric Barantal added a comment - 1 commit for change of API endpoint, 4 for upgrade to volumes* methods with unit tests.
        Hide
        kami Tomaz Muraus added a comment -

        Just wondering - why did you change the API endpoint URL?

        I would assume that https://rpc.gandi.net/xmlrpc/ always points to the latest API version and it's better to pin the driver to a specific version against which the driver has been tested.

        Show
        kami Tomaz Muraus added a comment - Just wondering - why did you change the API endpoint URL? I would assume that https://rpc.gandi.net/xmlrpc/ always points to the latest API version and it's better to pin the driver to a specific version against which the driver has been tested.
        Hide
        kami Tomaz Muraus added a comment -

        Can you please also create a normal patch file - you can find the instructions at http://libcloud.apache.org/contributing.html. The one you have attached is a git patch which means I can't easily apply it to the SVN repository.

        Show
        kami Tomaz Muraus added a comment - Can you please also create a normal patch file - you can find the instructions at http://libcloud.apache.org/contributing.html . The one you have attached is a git patch which means I can't easily apply it to the SVN repository.
        Hide
        mric Aymeric Barantal added a comment -

        Regarding API endpoint we decided to manage strictly deployment of new releases to only one URL. We have to make needed work during development and deployment cycles to ensure compatibility with current usage and new functionalities we introduce.Used libcloud drivers (reported by user agent string in HTTP logs) are tested with new releases of our API to ensure such compatibility.

        Previous API endpoint will be discontinued in 6 months at least (if no more used)

        I'll send a normal patch file, sorry for not reading carefully this point in the linked contributing page.

        Show
        mric Aymeric Barantal added a comment - Regarding API endpoint we decided to manage strictly deployment of new releases to only one URL. We have to make needed work during development and deployment cycles to ensure compatibility with current usage and new functionalities we introduce.Used libcloud drivers (reported by user agent string in HTTP logs) are tested with new releases of our API to ensure such compatibility. Previous API endpoint will be discontinued in 6 months at least (if no more used) I'll send a normal patch file, sorry for not reading carefully this point in the linked contributing page.
        Hide
        mric Aymeric Barantal added a comment -

        Normal patch file, that can be applied to a svn repository

        Show
        mric Aymeric Barantal added a comment - Normal patch file, that can be applied to a svn repository
        Hide
        kami Tomaz Muraus added a comment -

        Merged into trunk, thanks.

        Next time please also make sure you generate the patch against the latest trunk version otherwise it makes it more painful for us to merge the patch.

        Show
        kami Tomaz Muraus added a comment - Merged into trunk, thanks. Next time please also make sure you generate the patch against the latest trunk version otherwise it makes it more painful for us to merge the patch.

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            mric Aymeric Barantal
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development