Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.1
    • Fix Version/s: 0.10.1
    • Component/s: Compute
    • Labels:
      None

      Description

      The current version of libcloud has support only for vCloud v0.8 and is incompatible with the recent version of vCloud v1.5.

      It would be nice if the newer version was supported by libcloud: http://communities.vmware.com/thread/302725

      1. LIBCLOUD-183-vcloud_1_5.patch
        119 kB
        Michal Galet
      2. create_node_ex_net.test.txt
        3 kB
        Sengor Kusturica
      3. create_node_ex_net.recommended.xml
        0.9 kB
        Sengor Kusturica
      4. LIBCLOUD-183-vcloud_1_5-2.patch
        122 kB
        Michal Galet
      5. LIBCLOUD-183-vcloud_1_5-3.patch
        122 kB
        Michal Galet
      6. LIBCLOUD-183-vcloud_1_5-4.patch
        0.8 kB
        Sengor Kusturica
      7. LIBCLOUD-183-networks-typo.patch
        1 kB
        Michal Galet
      8. LIBCLOUD-183-vcloud_1_5-5.patch
        93 kB
        Sengor Kusturica
      9. LIBCLOUD-183-vcloud_1_5-5fixed.patch
        93 kB
        Michal Galet

        Activity

        Hide
        Tomaz Muraus added a comment -

        Can you please also attach a patch with the actual driver code and tests?

        Thanks.

        Show
        Tomaz Muraus added a comment - Can you please also attach a patch with the actual driver code and tests? Thanks.
        Hide
        Michal Galet added a comment -

        Here is the patch. I tried to leave the original 0.8 implementation backward compatible as much as possible.

        However one of the breaking changes might be the change where the "VCloudNodeDriver.vdcs()" function now returns a list of Vdc objects instead of a list of links. Please verify this change.

        Show
        Michal Galet added a comment - Here is the patch. I tried to leave the original 0.8 implementation backward compatible as much as possible. However one of the breaking changes might be the change where the "VCloudNodeDriver.vdcs()" function now returns a list of Vdc objects instead of a list of links. Please verify this change.
        Hide
        Sengor Kusturica added a comment -

        Thank you for the patch. For API v1.5 this patch works on vanilla VMware vCloud lab deployment for the following tasks:

        • create_node(name="test", image=images[0])
        • destroy_node(nodes[0])
        • list_nodes()
        • list_images()

        This patch did not work for me when ex_network is specified due to malformed XML request body (not compliant with official vApp.xsd). See attached "create_node_ex_net.test.txt" along with an example on how the request body should look "create_node_ex_net.recommended.xml"

        I recommend using the following default headers as to my knowledge cookie method is not officially supported under v1.5 API spec:

        { 'Accept': 'application/*+xml;version=1.5', 'x-vcloud-authorization': self.token }
        Show
        Sengor Kusturica added a comment - Thank you for the patch. For API v1.5 this patch works on vanilla VMware vCloud lab deployment for the following tasks: create_node(name="test", image=images [0] ) destroy_node(nodes [0] ) list_nodes() list_images() This patch did not work for me when ex_network is specified due to malformed XML request body (not compliant with official vApp.xsd). See attached "create_node_ex_net.test.txt" along with an example on how the request body should look "create_node_ex_net.recommended.xml" I recommend using the following default headers as to my knowledge cookie method is not officially supported under v1.5 API spec: { 'Accept': 'application/*+xml;version=1.5', 'x-vcloud-authorization': self.token }
        Hide
        Sengor Kusturica added a comment -

        test result with create_node & ex_network

        Show
        Sengor Kusturica added a comment - test result with create_node & ex_network
        Hide
        Sengor Kusturica added a comment -

        Recommended request body for create_node & ex_network

        Show
        Sengor Kusturica added a comment - Recommended request body for create_node & ex_network
        Hide
        Michal Galet added a comment -

        Thank you Sengor for testing it. I fixed the problem and after testing I will attach a new patch here tomorrow.

        Show
        Michal Galet added a comment - Thank you Sengor for testing it. I fixed the problem and after testing I will attach a new patch here tomorrow.
        Hide
        Michal Galet added a comment -

        Here is a fixed version of the patch with all suggestions provided by Sengor. Thank you Sengor.

        Show
        Michal Galet added a comment - Here is a fixed version of the patch with all suggestions provided by Sengor. Thank you Sengor.
        Hide
        Tomaz Muraus added a comment -

        I've applied the patch (LIBCLOUD-183-vcloud_1_5-2.patch) against the latest master and the tests fail with the following error:

        Traceback (most recent call last):
        File "/w/lc/trunk/test/compute/test_vcloud.py", line 164, in test_ex_undeploy_with_error
        node = self.driver.ex_undeploy_node(Node('https://test/api/vApp/undeployErrorTest', 'testNode', state=0, public_ips=[], private_ips=[], driver=self.driver))
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 899, in ex_undeploy_node
        'Content-Type': 'application/vnd.vmware.vcloud.undeployVAppParams+xml'
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 239, in request
        self._get_auth_token()
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 711, in _get_auth_token
        raise InvalidCredsError()
        InvalidCredsError: 'Invalid credentials with the provider'

        Can you please have a look?

        Show
        Tomaz Muraus added a comment - I've applied the patch ( LIBCLOUD-183 -vcloud_1_5-2.patch) against the latest master and the tests fail with the following error: Traceback (most recent call last): File "/w/lc/trunk/test/compute/test_vcloud.py", line 164, in test_ex_undeploy_with_error node = self.driver.ex_undeploy_node(Node('https://test/api/vApp/undeployErrorTest', 'testNode', state=0, public_ips=[], private_ips=[], driver=self.driver)) File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 899, in ex_undeploy_node 'Content-Type': 'application/vnd.vmware.vcloud.undeployVAppParams+xml' File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 239, in request self._get_auth_token() File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 711, in _get_auth_token raise InvalidCredsError() InvalidCredsError: 'Invalid credentials with the provider' Can you please have a look?
        Hide
        Michal Galet added a comment -

        Here is a fixed patch. Sorry for that.

        Show
        Michal Galet added a comment - Here is a fixed patch. Sorry for that.
        Hide
        Sengor Kusturica added a comment -

        Test of network connected new node works with 1_5-3 patch.

        >>> conn.create_node(name="pytest-vcloud", image=images[0], ex_network="https://10.1.1.10/api/network/9080255a-13be-415a-b32a-88651c9adb1d", ex_vm_names=["test-vm01"])

        However it does produce slightly malformed XML request body section for fencing mode element (prefix "ns0"):
        <ns0:FenceMode xmlns:ns0="http://www.vmware.com/vcloud/v1.5">bridged</ns0:FenceMode>

        Show
        Sengor Kusturica added a comment - Test of network connected new node works with 1_5-3 patch. >>> conn.create_node(name="pytest-vcloud", image=images [0] , ex_network="https://10.1.1.10/api/network/9080255a-13be-415a-b32a-88651c9adb1d", ex_vm_names= ["test-vm01"] ) However it does produce slightly malformed XML request body section for fencing mode element (prefix "ns0"): <ns0:FenceMode xmlns:ns0="http://www.vmware.com/vcloud/v1.5">bridged</ns0:FenceMode>
        Hide
        Sengor Kusturica added a comment -

        Minor suggestion: updating VCloud_1_5_Connection._get_auth_token() to cater for token expiry (by default after 30min vCloud will expire inactive tokens).

        >>> nodes = conn.list_nodes()
        .....

        1. -------- begin 21362880:20927984 response ----------
          HTTP/1.1 403 Forbidden

        >>> conn.connection.token = None
        >>> nodes = conn.list_nodes()
        .....

        1. -------- begin 21343192:20927984 response ----------
          HTTP/1.1 200 OK
        Show
        Sengor Kusturica added a comment - Minor suggestion: updating VCloud_1_5_Connection._get_auth_token() to cater for token expiry (by default after 30min vCloud will expire inactive tokens). >>> nodes = conn.list_nodes() ..... -------- begin 21362880:20927984 response ---------- HTTP/1.1 403 Forbidden >>> conn.connection.token = None >>> nodes = conn.list_nodes() ..... -------- begin 21343192:20927984 response ---------- HTTP/1.1 200 OK
        Hide
        Tomaz Muraus added a comment -

        Patch looks pretty solid so I've merged initial support into trunk. Thanks!

        There are still some things which can be improved so it would be great if you could create new patches for those improvements:

        • test_networks test is failing (index out of range) - I temporary commented it out
        • fixing issued mentioned by Sengor
        • instead of implementing _wait_for_task_completion you should use libcloud.common.base.PollingConnection. For an example you can check existing Rackspace DNS driver.
        Show
        Tomaz Muraus added a comment - Patch looks pretty solid so I've merged initial support into trunk. Thanks! There are still some things which can be improved so it would be great if you could create new patches for those improvements: test_networks test is failing (index out of range) - I temporary commented it out fixing issued mentioned by Sengor instead of implementing _wait_for_task_completion you should use libcloud.common.base.PollingConnection. For an example you can check existing Rackspace DNS driver.
        Hide
        Sengor Kusturica added a comment -

        Fix for FenceMode namespace prefix. LIBCLOUD-183-vcloud_1_5-4.patch

        Show
        Sengor Kusturica added a comment - Fix for FenceMode namespace prefix. LIBCLOUD-183 -vcloud_1_5-4.patch
        Hide
        Sengor Kusturica added a comment -

        Fix network fencing mode namespace (ns0) tag prefix.

        Show
        Sengor Kusturica added a comment - Fix network fencing mode namespace (ns0) tag prefix.
        Hide
        Michal Galet added a comment -

        There was a typo introduced when merging the patch into the master repo. Here is a patch that fixes the typo and the test_networks test.

        Show
        Michal Galet added a comment - There was a typo introduced when merging the patch into the master repo. Here is a patch that fixes the typo and the test_networks test.
        Hide
        Tomaz Muraus added a comment -

        I'm a bit confused about the latest patch (LIBCLOUD-183-vcloud_1_5-4.patch). The lines which are located in this patch are already located in the trunk where the test fails.

        Show
        Tomaz Muraus added a comment - I'm a bit confused about the latest patch ( LIBCLOUD-183 -vcloud_1_5-4.patch). The lines which are located in this patch are already located in the trunk where the test fails.
        Hide
        Sengor Kusturica added a comment -

        My bad, please ignore LIBCLOUD-183-vcloud_1_5-4.patch

        Show
        Sengor Kusturica added a comment - My bad, please ignore LIBCLOUD-183 -vcloud_1_5-4.patch
        Hide
        Sengor Kusturica added a comment -
        Show
        Sengor Kusturica added a comment - Latest changes from https://github.com/galet/libcloud/commits/LIBCLOUD-183
        Hide
        Michal Galet added a comment -

        I tested the attached LIBCLOUD-183-vcloud_1_5-5.patch and I can confirm that it works for me. It contains number of useful additions to the existing functionality as well as new methods that makes the implementation more complete.

        Show
        Michal Galet added a comment - I tested the attached LIBCLOUD-183 -vcloud_1_5-5.patch and I can confirm that it works for me. It contains number of useful additions to the existing functionality as well as new methods that makes the implementation more complete.
        Hide
        Tomaz Muraus added a comment - - edited

        I tried applying latest patch (LIBCLOUD-183-vcloud_1_5-5.patch) to trunk, but it fails. Can you please have a look? As a consequence a bunch of tests also fails.

        patching file libcloud/compute/drivers/vcloud.py
        Hunk #11 FAILED at 802.
        Hunk #12 succeeded at 946 (offset -1 lines).
        Hunk #13 succeeded at 1128 (offset -1 lines).
        Hunk #14 succeeded at 1191 (offset -1 lines).
        Hunk #15 succeeded at 1280 (offset -1 lines).
        1 out of 15 hunks FAILED – saving rejects to file libcloud/compute/drivers/vcloud.py.rej
        patching file test/compute/fixtures/vcloud_1_5/api_org_96726c78_4ae3_402f_b08b_7a78c6903d2a.xml
        patching file test/compute/fixtures/vcloud_1_5/api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6a.xml
        patching file test/compute/fixtures/vcloud_1_5/api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b.xml
        patching file test/compute/fixtures/vcloud_1_5/api_vApp_vm_test.xml
        patching file test/compute/fixtures/vcloud_1_5/api_vdc_3d9ae28c_1de9_4307_8107_9356ff8ba6d0.xml
        patching file test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_cpu.xml
        patching file test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_disks.xml
        patching file test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_memory.xml
        patching file test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_cpu.xml
        patching file test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_disks.xml
        patching file test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_memory.xml
        patching file test/compute/test_vcloud.py
        Reversed (or previously applied) patch detected! Assume -R? [n]


        ...
        ======================================================================
        ERROR: test_list_nodes_response (test.compute.test_vcloud.VCloud_1_5_Tests)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
        File "/w/lc/trunk/test/compute/_init_.py", line 25, in test_list_nodes_response
        nodes = self.driver.list_nodes()
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 504, in list_nodes
        raise e
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 495, in list_nodes
        headers=

        {'Content-Type': 'application/vnd.vmware.vcloud.vApp+xml'}

        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 254, in request
        return super(VCloudConnection, self).request(*args, **kwargs)
        File "/w/lc/trunk/libcloud/common/base.py", line 562, in request
        headers=headers)
        File "/w/lc/trunk/test/_init_.py", line 161, in request
        meth = getattr(self, meth_name)
        AttributeError: 'VCloud_1_5_MockHttp' object has no attribute '_api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b'

        ======================================================================
        ERROR: test_reboot_node (test.compute.test_vcloud.VCloud_1_5_Tests)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
        File "/w/lc/trunk/test/compute/test_vcloud.py", line 136, in test_reboot_node
        node = self.driver.list_nodes()[0]
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 504, in list_nodes
        raise e
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 495, in list_nodes
        headers=

        {'Content-Type': 'application/vnd.vmware.vcloud.vApp+xml'}

        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 254, in request
        return super(VCloudConnection, self).request(*args, **kwargs)
        File "/w/lc/trunk/libcloud/common/base.py", line 562, in request
        headers=headers)
        File "/w/lc/trunk/test/_init_.py", line 161, in request
        meth = getattr(self, meth_name)
        AttributeError: 'VCloud_1_5_MockHttp' object has no attribute '_api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b'

        ======================================================================
        ERROR: test_reboot_node_response (test.compute.test_vcloud.VCloud_1_5_Tests)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
        File "/w/lc/trunk/test/compute/_init_.py", line 75, in test_reboot_node_response
        node = self.driver.list_nodes()[0]
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 504, in list_nodes
        raise e
        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 495, in list_nodes
        headers=

        {'Content-Type': 'application/vnd.vmware.vcloud.vApp+xml'}

        File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 254, in request
        return super(VCloudConnection, self).request(*args, **kwargs)
        File "/w/lc/trunk/libcloud/common/base.py", line 562, in request
        headers=headers)
        File "/w/lc/trunk/test/_init_.py", line 161, in request
        meth = getattr(self, meth_name)
        AttributeError: 'VCloud_1_5_MockHttp' object has no attribute '_api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b'
        ...

        Show
        Tomaz Muraus added a comment - - edited I tried applying latest patch ( LIBCLOUD-183 -vcloud_1_5-5.patch) to trunk, but it fails. Can you please have a look? As a consequence a bunch of tests also fails. patching file libcloud/compute/drivers/vcloud.py Hunk #11 FAILED at 802. Hunk #12 succeeded at 946 (offset -1 lines). Hunk #13 succeeded at 1128 (offset -1 lines). Hunk #14 succeeded at 1191 (offset -1 lines). Hunk #15 succeeded at 1280 (offset -1 lines). 1 out of 15 hunks FAILED – saving rejects to file libcloud/compute/drivers/vcloud.py.rej patching file test/compute/fixtures/vcloud_1_5/api_org_96726c78_4ae3_402f_b08b_7a78c6903d2a.xml patching file test/compute/fixtures/vcloud_1_5/api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6a.xml patching file test/compute/fixtures/vcloud_1_5/api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b.xml patching file test/compute/fixtures/vcloud_1_5/api_vApp_vm_test.xml patching file test/compute/fixtures/vcloud_1_5/api_vdc_3d9ae28c_1de9_4307_8107_9356ff8ba6d0.xml patching file test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_cpu.xml patching file test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_disks.xml patching file test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_memory.xml patching file test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_cpu.xml patching file test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_disks.xml patching file test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_memory.xml patching file test/compute/test_vcloud.py Reversed (or previously applied) patch detected! Assume -R? [n] ... ====================================================================== ERROR: test_list_nodes_response (test.compute.test_vcloud.VCloud_1_5_Tests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/w/lc/trunk/test/compute/_ init _.py", line 25, in test_list_nodes_response nodes = self.driver.list_nodes() File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 504, in list_nodes raise e File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 495, in list_nodes headers= {'Content-Type': 'application/vnd.vmware.vcloud.vApp+xml'} File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 254, in request return super(VCloudConnection, self).request(*args, **kwargs) File "/w/lc/trunk/libcloud/common/base.py", line 562, in request headers=headers) File "/w/lc/trunk/test/_ init _.py", line 161, in request meth = getattr(self, meth_name) AttributeError: 'VCloud_1_5_MockHttp' object has no attribute '_api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b' ====================================================================== ERROR: test_reboot_node (test.compute.test_vcloud.VCloud_1_5_Tests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/w/lc/trunk/test/compute/test_vcloud.py", line 136, in test_reboot_node node = self.driver.list_nodes() [0] File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 504, in list_nodes raise e File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 495, in list_nodes headers= {'Content-Type': 'application/vnd.vmware.vcloud.vApp+xml'} File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 254, in request return super(VCloudConnection, self).request(*args, **kwargs) File "/w/lc/trunk/libcloud/common/base.py", line 562, in request headers=headers) File "/w/lc/trunk/test/_ init _.py", line 161, in request meth = getattr(self, meth_name) AttributeError: 'VCloud_1_5_MockHttp' object has no attribute '_api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b' ====================================================================== ERROR: test_reboot_node_response (test.compute.test_vcloud.VCloud_1_5_Tests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/w/lc/trunk/test/compute/_ init _.py", line 75, in test_reboot_node_response node = self.driver.list_nodes() [0] File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 504, in list_nodes raise e File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 495, in list_nodes headers= {'Content-Type': 'application/vnd.vmware.vcloud.vApp+xml'} File "/w/lc/trunk/libcloud/compute/drivers/vcloud.py", line 254, in request return super(VCloudConnection, self).request(*args, **kwargs) File "/w/lc/trunk/libcloud/common/base.py", line 562, in request headers=headers) File "/w/lc/trunk/test/_ init _.py", line 161, in request meth = getattr(self, meth_name) AttributeError: 'VCloud_1_5_MockHttp' object has no attribute '_api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b' ...
        Hide
        Michal Galet added a comment -

        Here is a fixed version of the patch: LIBCLOUD-183-vcloud_1_5-5fixed.patch. The problem was caused by a difference between galet/libcloud/trunk and apache/libcloud/trunk. This has been fixed so it shouldn't happen any more.

        Applying the fixed patch succeeded on svn repo:
        $ svn patch LIBCLOUD-183-vcloud_1_5-5fixed.patch
        U libcloud/compute/drivers/vcloud.py
        U test/compute/fixtures/vcloud_1_5/api_org_96726c78_4ae3_402f_b08b_7a78c6903d2a.xml
        U test/compute/fixtures/vcloud_1_5/api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6a.xml
        A test/compute/fixtures/vcloud_1_5/api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b.xml
        A test/compute/fixtures/vcloud_1_5/api_vApp_vm_test.xml
        U test/compute/fixtures/vcloud_1_5/api_vdc_3d9ae28c_1de9_4307_8107_9356ff8ba6d0.xml
        A test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_cpu.xml
        A test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_disks.xml
        A test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_memory.xml
        A test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_cpu.xml
        A test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_disks.xml
        A test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_memory.xml
        U test/compute/test_vcloud.py

        All tests are passing.

        Show
        Michal Galet added a comment - Here is a fixed version of the patch: LIBCLOUD-183 -vcloud_1_5-5fixed.patch. The problem was caused by a difference between galet/libcloud/trunk and apache/libcloud/trunk. This has been fixed so it shouldn't happen any more. Applying the fixed patch succeeded on svn repo: $ svn patch LIBCLOUD-183 -vcloud_1_5-5fixed.patch U libcloud/compute/drivers/vcloud.py U test/compute/fixtures/vcloud_1_5/api_org_96726c78_4ae3_402f_b08b_7a78c6903d2a.xml U test/compute/fixtures/vcloud_1_5/api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6a.xml A test/compute/fixtures/vcloud_1_5/api_vApp_vapp_8c57a5b6_e61b_48ca_8a78_3b70ee65ef6b.xml A test/compute/fixtures/vcloud_1_5/api_vApp_vm_test.xml U test/compute/fixtures/vcloud_1_5/api_vdc_3d9ae28c_1de9_4307_8107_9356ff8ba6d0.xml A test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_cpu.xml A test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_disks.xml A test/compute/fixtures/vcloud_1_5/get_api_vApp_vm_test_virtualHardwareSection_memory.xml A test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_cpu.xml A test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_disks.xml A test/compute/fixtures/vcloud_1_5/put_api_vApp_vm_test_virtualHardwareSection_memory.xml U test/compute/test_vcloud.py All tests are passing.
        Hide
        Tomaz Muraus added a comment -

        Merged into trunk.

        Show
        Tomaz Muraus added a comment - Merged into trunk.

          People

          • Assignee:
            Tomaz Muraus
            Reporter:
            Michal Galet
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 96h
              96h
              Remaining:
              Remaining Estimate - 96h
              96h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development