[LENS-775] NPE on closing HadoopFileFormatter

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.4
• Assignee: Deepak Barr
• Reporter: Deepak Barr
• Created: 16/Sep/15 06:32
• Updated: 17/Nov/15 11:49
• Resolved: 17/Sep/15 13:42

Description

In HadoopFileFormatter, If rowWriter intialization fails because of,say, HDFS permission issue. The close() method (called in finally block in ResultFormatter class) throws an NPE.

Code snippet -

public void setupOutputs() throws IOException {
String pathStr = ctx.getResultSetParentDir();
if (StringUtils.isBlank(pathStr))

{ throw new IllegalArgumentException("No output path specified"); }

String outputPathStr = Strings.isNullOrEmpty(ctx.getQueryName()) ? ""
: LensFileOutputFormat.getValidOutputFileName(ctx.getQueryName()) + "-";
outputPath = new Path(pathStr, outputPathStr + ctx.getQueryHandle().toString());
Path tmpWorkPath = new Path(pathStr, ctx.getQueryHandle().toString() + ".tmp");
try

{ rowWriter = LensFileOutputFormat.createRecordWriter(ctx.getConf(), tmpWorkPath, Reporter.NULL, ctx.getCompressOutput(), ctx.getOuptutFileExtn(), ctx.getResultEncoding()); numRows=0; }

catch (IOException e)

{ throw new IllegalArgumentException("Could not create tmp path"); }

}

@Override
public void close() throws IOException

{ rowWriter.close(Reporter.NULL); }