[LENS-418] Remove usage of redundant fact_or_dimension_table_name from XPartition

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: api
• Assignee: Unassigned
• Reporter: Rajat Khandelwal
• Created: 18/Mar/15 07:02
• Updated: 31/Aug/15 11:30

Description

cli command is:

fact add partitions factname storagename filepath

example partition list is:

<x_partition_list xmlns="uri:lens:cube:0.1"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="uri:lens:cube:0.1 cube-0.1.xsd ">
  <partition fact_or_dimension_table_name="fact1" location="/tmp/fact1" update_period="HOURLY"
    xmlns="uri:lens:cube:0.1"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="uri:lens:cube:0.1 cube-0.1.xsd ">
    <time_partition_spec>
      <part_spec_element key="dt" value="2014-03-27T12:00:00"/>
    </time_partition_spec>
  </partition>
</x_partition_list>

Fact name is mentioned in command as well as the xml. What will happen if both are different?

In my opinion, the design should be the following:

command:

add partitions filepath

file will contain x_partition_list. which will contain a lot of `partition`s which can belong to different fact/dimtable and storages.

Thoughts?