Uploaded image for project: 'Apache Lens'
  1. Apache Lens
  2. LENS-1471

JoinCandidate's children should not share same instance of a storage candidate

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8
    • Component/s: cube
    • Labels:
      None
    • Flags:
      Patch

      Description

      The issue is in Join candidates of the kind Join[Union[a,b]; Union[a,c]]. If the instance of a is shared in different trees of a JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set exclusive measure phrase indices, and that is done via retain method of list. So let's say union1 is answering [0,1] measures and union2 is answering [2,3] measures, and since [0,1,2,3].retain([0,1]).retain([2,3]) == [], it ends up answering no measures at all

      1. LENS-1471.01.patch
        4 kB
        Rajat Khandelwal
      2. LENS-1471.02.patch
        4 kB
        Rajat Khandelwal
      3. LENS-1471.03.patch
        5 kB
        Rajat Khandelwal

        Activity

        Hide
        prongs Rajat Khandelwal added a comment -
        Show
        prongs Rajat Khandelwal added a comment - Created https://reviews.apache.org/r/62060/
        Hide
        prongs Rajat Khandelwal added a comment -

        Taking patch from reviewboard and attaching

        Show
        prongs Rajat Khandelwal added a comment - Taking patch from reviewboard and attaching
        Hide
        hadoopqa Hadoop QA added a comment -

        Applied patch: LENS-1471.01.patch and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1428/

        Show
        hadoopqa Hadoop QA added a comment - Applied patch: LENS-1471.01.patch and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1428/
        Hide
        prongs Rajat Khandelwal added a comment -

        Taking patch from reviewboard and attaching

        Show
        prongs Rajat Khandelwal added a comment - Taking patch from reviewboard and attaching
        Hide
        hadoopqa Hadoop QA added a comment -

        Applied patch: LENS-1471.02.patch and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1429/

        Show
        hadoopqa Hadoop QA added a comment - Applied patch: LENS-1471.02.patch and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1429/
        Hide
        prongs Rajat Khandelwal added a comment -

        Taking patch from reviewboard and attaching

        Show
        prongs Rajat Khandelwal added a comment - Taking patch from reviewboard and attaching
        Hide
        hadoopqa Hadoop QA added a comment -

        Applied patch: LENS-1471.03.patch and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1430/

        Show
        hadoopqa Hadoop QA added a comment - Applied patch: LENS-1471.03.patch and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1430/
        Hide
        prongs Rajat Khandelwal added a comment -

        Committed myself.

        Show
        prongs Rajat Khandelwal added a comment - Committed myself.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Lens-Commit #1439 (See https://builds.apache.org/job/Lens-Commit/1439/)
        LENS-1471: JoinCandidate's children should not share same storage (rajatgupta59: rev caf7a2c0b045ce409d254c1ff26ffd79d01fee52)

        • (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
        • (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
        • (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Lens-Commit #1439 (See https://builds.apache.org/job/Lens-Commit/1439/ ) LENS-1471 : JoinCandidate's children should not share same storage (rajatgupta59: rev caf7a2c0b045ce409d254c1ff26ffd79d01fee52) (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java

          People

          • Assignee:
            prongs Rajat Khandelwal
            Reporter:
            prongs Rajat Khandelwal
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development