Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-771

DateUtils.ceiling does not behave correctly for dates on the boundaries

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.0.1
    • Fix Version/s: Patch Needed
    • Component/s: lang.time.*
    • Labels:
      None
    • Environment:

      Windows XP Professional
      Java 1.6

      Description

      DateUtils.ceiling does not behave as expected for dates exactly on the boundaries specified.

      To be consistent with the name "ceiling", it follows that if a date is already at its "ceiling", it should not be pushed any higher. Yet the current implementation (and, it would appear, all implementations since its creation) of DateUtils.ceiling push a value exactly on its ceiling to the next value.

      Observe what happens if the following tests are added to DateUtilsTest.testCeil():

               double double4 = 15.0;
               assertEquals("ceiling double-4 failed",
               		double4,
               		Math.ceil(double4));
               
               Date date4 = dateTimeParser.parse("March 30, 2003 01:10:00.000");
               assertEquals("ceiling minute-4 failed",
               		date4,
               		DateUtils.ceiling(date4, Calendar.MINUTE));
      

      The first assert passes, as Math.ceil behaves as it should (i.e. Mail.ceil(15.0) = 15.0).

      However, the second assert fails with:

         ceiling minute-4 failed expected:<Sun Mar 30 01:10:00 GMT+08:00 2003> but was:<Sun Mar 30 01:11:00 GMT+08:00 2003>
      

      as the routine incorrectly (I believe) pushes the value to the next minute.

      Either the method is incorrectly named (as previously suggested) or it should probably be corrected to be consistent with expected behaviour (using Math.ceil as a benchmark).

      If changing the behaviour of DateUtils.ceiling is perceived to have too many flow-on effects (e.g. backwards compatibility issues) then perhaps it should be renamed to DateUtils.ceil to make it consistent with the Math class method name and to make the change in behaviour obvious (and perhaps also have a DateUtils.floor as a synonym for DateUtils.truncate).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                rizariza Ryan Holmes
              • Votes:
                3 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: