[LANG-636] text.ExtendedMessageFormat doesn't override java.text.MessageFormat.equals(Object)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6
• Component/s: lang.text.*
• Assignee: Niall Pemberton
• Reporter: Sebb
• Created: 21/Jul/10 10:55
• Updated: 03/Feb/11 05:26
• Resolved: 11/Jan/11 00:28

Description

Findbugs:

Bug: org.apache.commons.lang3.text.ExtendedMessageFormat doesn't override java.text.MessageFormat.equals(Object)
Pattern id: EQ_DOESNT_OVERRIDE_EQUALS, type: Eq, category: STYLE

This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o).