[LANG-474] Fixes for thread safety

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0
• Component/s: General
• Assignee: Unassigned
• Reporter: Sebb
• Created: 26/Nov/08 19:10
• Updated: 17/Dec/09 03:42
• Resolved: 11/Aug/09 06:39

Description

org.apache.commons.lang.exception.NestableDelegate

• the static boolean fields should probably be made volatile to ensure that they are visible across threads
  If not, the Javadoc should be updated to note that changing the setting renders the class not thread-safe.
• the "nestable" field should be declared final

org.apache.commons.lang.exception.NestableError / NestableRuntimeException / NestableException

• Fields "cause" and "delegate" should be made final to improve thread-safety

The following fields could be made final:
org.apache.commons.lang.text.ExtendedMessageFormat.registry
org.apache.commons.lang.text.StrMatcher - class variables in nested classes could be made final
org.apache.commons.lang.CharSet.set

Also:
org.apache.commons.lang.IntHashMap.Entry - the field "key" is never used