[LANG-1726] ExceptionUtils.asRuntimeException is not a good replacement for deprecated ExceptionUtils.rethrow

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.14.0
• Fix Version/s: 3.15.0
• Component/s: lang.exception.*
• Assignee: Unassigned
• Reporter: Václav Haisman
• Created: 04/Jan/24 16:05
• Updated: 20/Jan/24 20:53
• Resolved: 04/Jan/24 20:23

Description

I have been doing pass over deprecated warning in our code and one of them is that org.apache.commons.lang3.exception.ExceptionUtils#rethrow is deprecated. Its comment says "Use asRuntimeException(Throwable)." However, asRuntimeException() is not a good replacement. It lacks the generic type parameter R that the rethrow method has. In fact, the comment that says...

Returns:
Never actually returned, this generic type matches any type which the calling site requires. [..]

...is lying.