[LANG-1518] MethodUtils.getAnnotation() with searchSupers = true does not work if super is generic

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.9
• Fix Version/s: 3.10
• Component/s: lang.reflect.*
• Assignee: Unassigned
• Reporter: Michele Preti
• Created: 18/Feb/20 13:03
• Updated: 24/Feb/20 12:35
• Resolved: 22/Feb/20 13:28

Description

 

public static class Foo<T> {
	@Nonnull
	protected void test(T i) {
		System.out.println("foo" + i);
	}
}

public static class Bar extends Foo<Integer> {
	@Override
	protected void test(Integer i) {
		System.out.println("bar" + i);
	}
}

public static void main(String[] args) throws NoSuchMethodException, SecurityException {
	Method testMethod = Bar.class.getDeclaredMethod("test", Integer.class);
	
	System.out.println(MethodUtils.getAnnotation(testMethod, Nonnull.class, true, true)); //==null
}

 

the method MethodUtils.getAnnotation() should be modified as souch:

(using MethodUtils.getMatchingMethod/MethodUtils.getMatchingAccessibleMethod instead of getDeclaredMethod/getMethod)

public static <A extends Annotation> A getAnnotation(final Method method, final Class<A> annotationCls,
		final boolean searchSupers, final boolean ignoreAccess) {

	Validate.isTrue(method != null, "The method must not be null");
	Validate.isTrue(annotationCls != null, "The annotation class must not be null");
	if (!ignoreAccess && !MemberUtils.isAccessible(method)) {
		return null;
	}

	A annotation = method.getAnnotation(annotationCls);

	if (annotation == null && searchSupers) {
		final Class<?> mcls = method.getDeclaringClass();
		final List<Class<?>> classes = getAllSuperclassesAndInterfaces(mcls);
		for (final Class<?> acls : classes) {
			Method equivalentMethod = (ignoreAccess
					? MethodUtils.getMatchingMethod(acls, method.getName(), method.getParameterTypes())
					: MethodUtils.getMatchingAccessibleMethod(acls, method.getName(), method.getParameterTypes()));
			if (equivalentMethod == null) {
				continue;
			}
			annotation = equivalentMethod.getAnnotation(annotationCls);
			if (annotation != null) {
				break;
			}
		}
	}

	return annotation;
}

 

 

Issue Links

• links to: GitHub Pull Request #494