Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-1262

CompareToBuilder.append(Object,Object,Comparator) method is too big to be inlined

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.5
    • Component/s: lang.builder.*
    • Labels:
      None

      Description

      Issue is the same as in LANG-1218: CompareToBuilder.append(Object,Object,Comparator) is quite big, due to in-place arrays processing, and thus breaching inlining threshold (325 bytecodes):

      ....
      o.a.c.l.b.CompareToBuilder::append (346 bytes)   hot method too big
      ....
      

      This prevents CompareToBuilder object itself from being scalarized.

      Fix may be the same, as in LANG-1218: extract arrays processing into separate method.

        Attachments

          Activity

            People

            • Assignee:
              pascalschumacher Pascal Schumacher
              Reporter:
              cheremin Ruslan Cheremin

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment