[KYLIN-4478] Usage of "AES/ECB/PKCS5Padding" is insecure

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: v3.1.0
• Sprint: Sprint 52
• Assignee: Md Mahir Asef Kabir
• Reporter: Md Mahir Asef Kabir
• Created: 04/May/20 01:57
• Updated: 10/Jul/20 12:20
• Resolved: 12/Jun/20 06:58

Description

Vulnerability Description: In “core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java” file the following code was written in public static String encrypt(String strToEncrypt) method -

Cipher cipher = Cipher.getInstance("AES/ECB/PKCS5Padding");

The vulnerability is, using "AES/ECB/PKCS5Padding” as the argument to Cipher.getInstance method.

Reason it’s vulnerable: ”AES/ECB/PKCS5Padding” is not secure. For further reference, follow this.

Suggested Fix: Using

Cipher cipher = Cipher.getInstance("AES/CFB/PKCS5Padding");

Feedback: Please select any of the options down below to help us get an idea about how you felt about the suggestion -

1. Liked it and will make the suggested changes
2. Liked it but happy with the existing version
3. Didn’t find the suggestion helpful

Issue Links

• is duplicated by: KYLIN-4479 Usage of "AES/ECB/PKCS5Padding" is insecure