[KYLIN-4132] Kylin needn't use "org.apache.directory.api.util.Strings" to import api-util.jar

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: v3.0.2, v2.6.6
• Component/s: REST Service
• Environment: Fusion Insight
• Assignee: Wang Rupeng
• Reporter: zhao jintao
• Due: 06/Sep/19
• Created: 13/Aug/19 06:06
• Updated: 06/May/20 08:41
• Resolved: 02/Mar/20 14:38

Description

Hi Team:

I read kylin code find that JobService class and ProjectService class import "org.apache.directory.api.util.Strings"  use the function of "Strings.isEmpty(String)" from "api-util.jar"  to judge whether a string is empty.

 This function can be replaced by importing "org.apache.commons.lang.StringUtils"  use "StringUtils.isEmpty(String)" from “common-lang.jar”.

The "api-util.jar" was  dependent by hbase-client. When kylin build&package, there isn't "api-util.jar" in kylin.war. When start kylin process, it will be imported from hbase client lib. But if hbase client doesn't dependency "api-util.jar", kylin running failed and  will throw exception.

In fact, I encountered this problem in the latest Fusion-Insignt version. Kylin start failed because there isn't "api-util.jar" in hbase client lib.

 

So I suggest  replace "org.apache.directory.api.util.Strings.isEmpty(String)" to "org.apache.commons.lang.StringUtils.isEmpty(String)" to avoid this problem.

Best wishes

Yours   zjt.

Issue Links

• links to: GitHub Pull Request #1129