[KYLIN-4131] Broadcaster memory leak

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: v3.0.0, v2.6.4
• Component/s: Metadata
• Assignee: Chao Long
• Reporter: Chao Long
• Created: 12/Aug/19 09:23
• Updated: 13/Oct/19 00:37
• Resolved: 02/Sep/19 02:38

Description

Test evidence

Use MAT(Memory Analyzer) to analyze this issue.

1. start  Kylin, dump a jvm heap info snapshot and import into MAT. We can see there is only one Broadcaster and ProjectManager object.
   

1. Call 'list cube' api and 'reload metadata' api many times. We can see there are many BroadCaster and Manager objects in the memory, which should be recycled by GC, but they are not.
   

 

Root cause

Broadcaster hold the ref of Listener object defined in Manager, and the Listener object hold the ref of Manager, because the impl class of Listener is an inner class of Manager.

Broadcaster.java

private Map<String, List<Listener>> listenerMap = Maps.newConcurrentMap();

 ProjectManager.java -> ProjectSyncListener

private class ProjectSyncListener extends Broadcaster.Listener {

@Override
public void onEntityChange(Broadcaster broadcaster, String entity, Event event, String cacheKey)
throws IOException {
String project = cacheKey;

if (event == Event.DROP) {
removeProjectLocal(project);
return;
}

reloadProjectQuietly(project);
broadcaster.notifyProjectSchemaUpdate(project);
broadcaster.notifyProjectDataUpdate(project);
}
}

And Broadcaster can't be recycled by GC because it holds a running thread, which cause the Manager object also not being recycled.

After Fix

 The Broadcaster objects and Manager objects are recycled by GC.

 

Issue Links

• links to: GitHub Pull Request #799