Uploaded image for project: 'Kylin'
  1. Kylin
  2. KYLIN-4044

CuratorScheduler may throw NPE when init service Cache

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • v3.0.0
    • v3.0.0-alpha2
    • None
    • None

    Description

      Currently Kylin uses Curator 2.12.0 dependencies.
      There is an issue of CURATOR-452 which may affect Kylin Server Discovery.

      When kylin server starts, it will discover other kylin server nodes in ZK path, and then register itself to ZK path. Curator discovery and cache implementation will initialize the service cache and deserialize the ServiceInstance by * JsonInstanceSerializer* which implemented by Kylin.

      But the CURATOR-452 hasn't been back-ported to curator-2.x branch.

      This curator issue may pass a Null value in JsonInstanceSerializer#deserialize(byte[] bytes) and it will cause the NPE.

      Kylin now uses the zookeeper version dependency with version 3.4.13, so according to the curator compatibility in https://curator.apache.org/zk-compatibility.html#, I think it's safe to upgrade the Curator version to 4.0+ in Kylin

      Attachments

        Activity

          People

            PENG Zhengshuai PENG Zhengshuai
            PENG Zhengshuai PENG Zhengshuai
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: