[KYLIN-4027] Kylin-jdbc module has tcp resource leak

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: all
• Fix Version/s: v3.0.0-alpha2
• Component/s: Driver - JDBC
• Labels: easyfix
• Flags: Important
• Assignee: Unassigned
• Reporter: Hongsen Liu
• Created: 01/Jun/19 07:12
• Updated: 21/Jan/20 07:43
• Resolved: 17/Jul/19 07:10

Description

In Kylin-jdbc module, the class KylinClient has TCP resource leak when it sends  http request. For example,  like the following code snipper

 

HttpResponse response = httpClient.execute(post);
try {
     if (response.getStatusLine().getStatusCode() != 200 &&          response.getStatusLine().getStatusCode() != 201)

Unknown macro: {            throw asIOException(post, response);       }

        SQLResponseStub stub =  jsonMapper.readValue(           response.getEntity().getContent(), SQLResponseStub.class);
          return stub;
} finally

Unknown macro: {          post.releaseConnection(); }

The code HttpClient.execute(post) is not in try segment, if it throws exception internally ,

the finally segment won't run.

 

Issue Links

• links to: GitHub Pull Request #702