Uploaded image for project: 'Kylin'
  1. Kylin
  2. KYLIN-3842

kylinProperties.js Unable to get the public configuration of the first line in the front end

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: v2.5.2
    • Fix Version/s: Future, v3.0.0
    • Component/s: Web
    • Labels:
      None

      Description

      Hi dear team:
      I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found that kylinProperties.js:37(getProperty(name)) can't get the property of the first line in the '_config' which initialized through /admin/public_config.
      For example, the public config is 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
      kylin.web.hive-limit=20\nkylin.web.help.length=4\n'. I expected to get 20 but got '' when I want to get config by key 'kylin.restclient.connection.default-max-per-route'. This problem caused by 'var keyIndex = _config.indexOf('\n' + name + '=');'(at kylinProperties.js:37) return -1 for those names before which don't have an \n(at the first line).
      Then, I debug the AdminService.java, KylinConfig.java and found that the KylinConfig.java:517(around this line, in method exportToString(Collection<String> propertyKeys)) build the public config string with a char '\n' after each property, which cause the first property don't has '\n' before it.
      Those are what I found, which will cause problem for developers.
      How do you think?

      Best regard
      yuzhang

        Attachments

        1. KYLIN-3842.master.001.patch
          2 kB
          Vsevolod Ostapenko

          Activity

            People

            • Assignee:
              simpleyuzhang Yuzhang QIU
              Reporter:
              simpleyuzhang Yuzhang QIU
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: