[KYLIN-3669] Add log to GTStreamAggregateScanner

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: v2.5.2
• Component/s: Query Engine
• Assignee: Jiatao Tao
• Reporter: Jiatao Tao
• Created: 06/Nov/18 15:01
• Updated: 04/Dec/18 04:28
• Resolved: 26/Nov/18 11:02

Description

There's no log printing in GTStreamAggregateScanner, and you know nothing about whether you go to this path or not, it's pretty unfriendly for trouble shooting.

Code in SegmentCubeTupleIterator.

boolean hasMultiplePartitions = records instanceof SortMergedPartitionResultIterator;
if (hasMultiplePartitions && context.isStreamAggregateEnabled()) {
    ...
    // input records are ordered, leverage stream aggregator to produce possibly fewer records
    try (GTStreamAggregateScanner aggregator = new GTStreamAggregateScanner(inputScanner, scanRequest)) {
        result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx);
    } catch (IOException ioe) {
        // implementation of close method of anonymous IGTScanner is empty, no way throw exception
        throw new IllegalStateException("IOException is not expected here.", ioe);
    }
    return result;
}

Issue Links

• links to: GitHub Pull Request #352