[KYLIN-3630] Remove unused fields in the implementations of MeasureType

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: v2.6.0
• Assignee: Jiatao Tao
• Reporter: Jiatao Tao
• Created: 14/Oct/18 10:57
• Updated: 15/Oct/18 02:20
• Resolved: 15/Oct/18 02:20

Description

In code RawMeasureType#RawMeasureType, we can see that both funcName and dataType are use, and this can be remove cuz there's no constraint on its constructor.

    @SuppressWarnings("unused")
    private final DataType dataType;

    public RawMeasureType(String funcName, DataType dataType) {
        this.dataType = dataType;
    }

And after we done that, we can more easily test MeasureType without passing in meaningless args(AggregatorMemEstimateTest#112).

Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType, other implementations can be cleaner.

        @Override
        public MeasureType<Object> createMeasureType(String funcName, DataType dataType) {
            return new DimCountDistinctMeasureType();
        }

Issue Links

• links to: GitHub Pull Request #289