Uploaded image for project: 'Kylin'
  1. Kylin
  2. KYLIN-3146

Response code and exception should be standardised for cube checking

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v2.5.0
    • Component/s: None
    • Labels:
      None

      Description

      Checking if cubes exist or not is a common behaviour in some APIs. But we have lots of different responses for the same behaviour.
      Let's take CubeController as an example. When can not find a cube with its name, someone gives a 400 as response code, someone returns 404, and others send back a 500. Not only HTTP response code is not standard, which kind of exception should be thrown is not unified as well. Still using the above example, we can find IllegalArgumentException, BadRequestException, InternalErrorException.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              liukaige Kaige Liu
              Reporter:
              liukaige Kaige Liu

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment