Uploaded image for project: 'Kylin'
  1. Kylin
  2. KYLIN-3004

Update validation when deleting segment

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: v2.1.0
    • Fix Version/s: v2.3.0
    • Component/s: REST Service
    • Labels:
      None

      Description

      In version 2.1, kylin allow hole between segment.
      But currently, there is validation for delete segment.
      Here is the code in CubeService:
      if (!segmentName.equals(cube.getSegments().get(0).getName())
      && !segmentName.equals(cube.getSegments().get(cube.getSegments().size() - 1).getName()))

      { throw new BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(), segmentName)); }

      Does it make sense? Should we remove the limit?

        Attachments

        1. KYLIN_3004.patch
          2 kB
          Julian Pan
        2. KYLIN_3004.patch
          3 kB
          Julian Pan

          Issue Links

            Activity

              People

              • Assignee:
                julianpan Julian Pan
                Reporter:
                julianpan Julian Pan
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: